Skip to content

Commit 112f7d3

Browse files
committed
ALSA: hda: Avoid binding with SOF for SKL/KBL platforms
For Intel SKL and KBL platforms, it may be bound with one of three HD-audio drivers (AVS, SOF and legacy). AVS is the preferred one when DMIC is detected, and that's how it's defined in the snd-intel-dspcfg config table. But, when AVS driver is disabled (CONFIG_SND_SOC_INTEL_AVS=n), the device may be bound freely with either SOF or legacy driver. Before 6.17, the legacy driver took it primarily, but on 6.17, likely due to the recent code shuffling, SOF driver seems taking it at first, and fails to probe. For avoiding the regression, we should enforce to bind those with the legacy HD-audio drvier when AVS is disabled. This patch adds the extra two entries in intel-dspcfg table that are applied only when CONFIG_SND_SOC_INTEL_AVS=n, for binding with the legacy driver. Note that there are entries for APL in that config table block, but APL may be supported by SOF for certain setups, so the choice can't be exclusive. Hence this patch includes only SKL and KBL. Link: https://bugzilla.suse.com/show_bug.cgi?id=1248121 Reviewed-by: Cezary Rojewski <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent f600bdd commit 112f7d3

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

sound/hda/core/intel-dsp-config.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,13 @@ static const struct config_entry config_table[] = {
116116
.flags = FLAG_SST,
117117
.device = PCI_DEVICE_ID_INTEL_HDA_FCL,
118118
},
119+
#else /* AVS disabled; force to legacy as SOF doesn't work for SKL or KBL */
120+
{
121+
.device = PCI_DEVICE_ID_INTEL_HDA_SKL_LP,
122+
},
123+
{
124+
.device = PCI_DEVICE_ID_INTEL_HDA_KBL_LP,
125+
},
119126
#endif
120127
#if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE)
121128
{

0 commit comments

Comments
 (0)