Skip to content

Commit 1443a9f

Browse files
Matthew Wilcox (Oracle)akpm00
authored andcommitted
minix: remove writepage implementation
If the filesystem implements migrate_folio and writepages, there is no need for a writepage implementation. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Matthew Wilcox (Oracle) <[email protected]> Reviewed-by: Jens Axboe <[email protected]> Cc: Christoph Hellwig <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 44afc06 commit 1443a9f

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

fs/minix/inode.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include <linux/slab.h>
1818
#include <linux/init.h>
1919
#include <linux/highuid.h>
20+
#include <linux/mpage.h>
2021
#include <linux/vfs.h>
2122
#include <linux/writeback.h>
2223

@@ -397,9 +398,10 @@ static int minix_get_block(struct inode *inode, sector_t block,
397398
return V2_minix_get_block(inode, block, bh_result, create);
398399
}
399400

400-
static int minix_writepage(struct page *page, struct writeback_control *wbc)
401+
static int minix_writepages(struct address_space *mapping,
402+
struct writeback_control *wbc)
401403
{
402-
return block_write_full_page(page, minix_get_block, wbc);
404+
return mpage_writepages(mapping, wbc, minix_get_block);
403405
}
404406

405407
static int minix_read_folio(struct file *file, struct folio *folio)
@@ -444,9 +446,10 @@ static const struct address_space_operations minix_aops = {
444446
.dirty_folio = block_dirty_folio,
445447
.invalidate_folio = block_invalidate_folio,
446448
.read_folio = minix_read_folio,
447-
.writepage = minix_writepage,
449+
.writepages = minix_writepages,
448450
.write_begin = minix_write_begin,
449451
.write_end = generic_write_end,
452+
.migrate_folio = buffer_migrate_folio,
450453
.bmap = minix_bmap,
451454
.direct_IO = noop_direct_IO
452455
};

0 commit comments

Comments
 (0)