Skip to content

Commit 21d8525

Browse files
tiwaigregkh
authored andcommitted
usb: gadget: midi2: Fix missing UMP group attributes initialization
The gadget card driver forgot to call snd_ump_update_group_attrs() after adding FBs, and this leaves the UMP group attributes uninitialized. As a result, -ENODEV error is returned at opening a legacy rawmidi device as an inactive group. This patch adds the missing call to address the behavior above. Fixes: 8b64592 ("usb: gadget: Add support for USB MIDI 2.0 function driver") Cc: stable <[email protected]> Signed-off-by: Takashi Iwai <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent f34bfcc commit 21d8525

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/usb/gadget/function/f_midi2.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1599,6 +1599,7 @@ static int f_midi2_create_card(struct f_midi2 *midi2)
15991599
strscpy(fb->info.name, ump_fb_name(b),
16001600
sizeof(fb->info.name));
16011601
}
1602+
snd_ump_update_group_attrs(ump);
16021603
}
16031604

16041605
for (i = 0; i < midi2->num_eps; i++) {

0 commit comments

Comments
 (0)