Skip to content

Commit 3200fdd

Browse files
jacob-kellerkuba-moo
authored andcommitted
broadcom: fix support for PTP_EXTTS_REQUEST2 ioctl
Commit 7c571ac ("net: ptp: introduce .supported_extts_flags to ptp_clock_info") modified the PTP core kernel logic to validate the supported flags for the PTP_EXTTS_REQUEST ioctls, rather than relying on each individual driver correctly checking its flags. The bcm_ptp_enable() function implements support for PTP_CLK_REQ_EXTTS, but does not check the flags, and does not forward the request structure into bcm_ptp_extts_locked(). When originally converting the bcm-phy-ptp.c code, it was unclear what edges the hardware actually timestamped. Thus, no flags were initialized in the .supported_extts_flags field. This results in the kernel automatically rejecting all userspace requests for the PTP_EXTTS_REQUEST2 ioctl. This occurs because the PTP_STRICT_FLAGS is always assumed when operating under PTP_EXTTS_REQUEST2. This has been the case since the flags introduction by commit 6138e68 ("ptp: Introduce strict checking of external time stamp options."). The bcm-phy-ptp.c logic never properly supported strict flag validation, as it previously ignored all flags including both PTP_STRICT_FLAGS and the PTP_FALLING_EDGE and PTP_RISING_EDGE flags. Reports from users in the field prove that the hardware timestamps the rising edge. Encode this in the .supported_extts_flags field. This re-enables support for the PTP_EXTTS_REQUEST2 ioctl. Reported-by: James Clark <[email protected]> Fixes: 7c571ac ("net: ptp: introduce .supported_extts_flags to ptp_clock_info") Signed-off-by: Jacob Keller <[email protected]> Reviewed-by: Vadim Fedorenko <[email protected]> Acked-by: Richard Cochran <[email protected]> Reviewed-by: Kory Maincent <[email protected]> Tested-by: James Clark <[email protected]> Link: https://patch.msgid.link/20250918-jk-fix-bcm-phy-supported-flags-v1-2-747b60407c9c@intel.com Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 6e6c88d commit 3200fdd

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/phy/bcm-phy-ptp.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -738,6 +738,7 @@ static const struct ptp_clock_info bcm_ptp_clock_info = {
738738
.n_per_out = 1,
739739
.n_ext_ts = 1,
740740
.supported_perout_flags = PTP_PEROUT_DUTY_CYCLE,
741+
.supported_extts_flags = PTP_STRICT_FLAGS | PTP_RISING_EDGE,
741742
};
742743

743744
static void bcm_ptp_txtstamp(struct mii_timestamper *mii_ts,

0 commit comments

Comments
 (0)