Skip to content

Commit 32b7144

Browse files
committed
Merge tag 'libcrypto-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux
Pull crypto library fixes from Eric Biggers: "Fix a regression where 'make clean' stopped removing some of the generated assembly files on arm and arm64" * tag 'libcrypto-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux: lib/crypto: ensure generated *.S files are removed on make clean lib/crypto: sha: Update Kconfig help for SHA1 and SHA256
2 parents eb4a099 + fd7e5de commit 32b7144

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

lib/crypto/Kconfig

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ config CRYPTO_LIB_CHACHA20POLY1305
140140
config CRYPTO_LIB_SHA1
141141
tristate
142142
help
143-
The SHA-1 library functions. Select this if your module uses any of
144-
the functions from <crypto/sha1.h>.
143+
The SHA-1 and HMAC-SHA1 library functions. Select this if your module
144+
uses any of the functions from <crypto/sha1.h>.
145145

146146
config CRYPTO_LIB_SHA1_ARCH
147147
bool
@@ -157,9 +157,9 @@ config CRYPTO_LIB_SHA1_ARCH
157157
config CRYPTO_LIB_SHA256
158158
tristate
159159
help
160-
Enable the SHA-256 library interface. This interface may be fulfilled
161-
by either the generic implementation or an arch-specific one, if one
162-
is available and enabled.
160+
The SHA-224, SHA-256, HMAC-SHA224, and HMAC-SHA256 library functions.
161+
Select this if your module uses any of these functions from
162+
<crypto/sha2.h>.
163163

164164
config CRYPTO_LIB_SHA256_ARCH
165165
bool

lib/crypto/Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,13 @@ ifeq ($(CONFIG_ARM),y)
100100
libsha256-y += arm/sha256-ce.o arm/sha256-core.o
101101
$(obj)/arm/sha256-core.S: $(src)/arm/sha256-armv4.pl
102102
$(call cmd,perlasm)
103-
clean-files += arm/sha256-core.S
104103
AFLAGS_arm/sha256-core.o += $(aflags-thumb2-y)
105104
endif
106105

107106
ifeq ($(CONFIG_ARM64),y)
108107
libsha256-y += arm64/sha256-core.o
109108
$(obj)/arm64/sha256-core.S: $(src)/arm64/sha2-armv8.pl
110109
$(call cmd,perlasm_with_args)
111-
clean-files += arm64/sha256-core.S
112110
libsha256-$(CONFIG_KERNEL_MODE_NEON) += arm64/sha256-ce.o
113111
endif
114112

@@ -132,15 +130,13 @@ ifeq ($(CONFIG_ARM),y)
132130
libsha512-y += arm/sha512-core.o
133131
$(obj)/arm/sha512-core.S: $(src)/arm/sha512-armv4.pl
134132
$(call cmd,perlasm)
135-
clean-files += arm/sha512-core.S
136133
AFLAGS_arm/sha512-core.o += $(aflags-thumb2-y)
137134
endif
138135

139136
ifeq ($(CONFIG_ARM64),y)
140137
libsha512-y += arm64/sha512-core.o
141138
$(obj)/arm64/sha512-core.S: $(src)/arm64/sha2-armv8.pl
142139
$(call cmd,perlasm_with_args)
143-
clean-files += arm64/sha512-core.S
144140
libsha512-$(CONFIG_KERNEL_MODE_NEON) += arm64/sha512-ce-core.o
145141
endif
146142

@@ -167,3 +163,7 @@ obj-$(CONFIG_PPC) += powerpc/
167163
obj-$(CONFIG_RISCV) += riscv/
168164
obj-$(CONFIG_S390) += s390/
169165
obj-$(CONFIG_X86) += x86/
166+
167+
# clean-files must be defined unconditionally
168+
clean-files += arm/sha256-core.S arm/sha512-core.S
169+
clean-files += arm64/sha256-core.S arm64/sha512-core.S

0 commit comments

Comments
 (0)