Skip to content

Commit 3f69f2e

Browse files
covanambjorn-helgaas
authored andcommitted
PCI: xilinx: Fix NULL pointer dereference in xilinx_pcie_intr_handler()
f29861a ("PCI: xilinx: Switch to msi_create_parent_irq_domain()") changed xilinx_pcie::msi_domain from child devices' interrupt domain to Xilinx AXI bridge's interrupt domain. However, xilinx_pcie_intr_handler() wasn't changed and still reads Xilinx AXI bridge's interrupt domain from xilinx_pcie::msi_domain->parent. This pointer is NULL now. Update xilinx_pcie_intr_handler() to read the correct interrupt domain pointer. Fixes: f29861a ("PCI: xilinx: Switch to msi_create_parent_irq_domain()") Signed-off-by: Nam Cao <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Link: https://patch.msgid.link/[email protected]
1 parent 8f5ae30 commit 3f69f2e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pci/controller/pcie-xilinx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ static irqreturn_t xilinx_pcie_intr_handler(int irq, void *data)
400400
if (val & XILINX_PCIE_RPIFR1_MSI_INTR) {
401401
val = pcie_read(pcie, XILINX_PCIE_REG_RPIFR2) &
402402
XILINX_PCIE_RPIFR2_MSG_DATA;
403-
domain = pcie->msi_domain->parent;
403+
domain = pcie->msi_domain;
404404
} else {
405405
val = (val & XILINX_PCIE_RPIFR1_INTR_MASK) >>
406406
XILINX_PCIE_RPIFR1_INTR_SHIFT;

0 commit comments

Comments
 (0)