Skip to content

Commit 486021e

Browse files
committed
perf annotate: Add more x86 mov instruction cases
Instructions with sign- and zero- extention like movsbl and movzwq were not handled properly. As it can check different size suffix (-b, -w, -l or -q) we can omit that and add the common parts even though some combinations are not possible. Reviewed-by: Ian Rogers <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Namhyung Kim <[email protected]>
1 parent 70360fa commit 486021e

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tools/perf/arch/x86/annotate/instructions.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,15 @@ static struct ins x86__instructions[] = {
7474
{ .name = "movdqa", .ops = &mov_ops, },
7575
{ .name = "movdqu", .ops = &mov_ops, },
7676
{ .name = "movsd", .ops = &mov_ops, },
77-
{ .name = "movslq", .ops = &mov_ops, },
7877
{ .name = "movss", .ops = &mov_ops, },
78+
{ .name = "movsb", .ops = &mov_ops, },
79+
{ .name = "movsw", .ops = &mov_ops, },
80+
{ .name = "movsl", .ops = &mov_ops, },
7981
{ .name = "movupd", .ops = &mov_ops, },
8082
{ .name = "movups", .ops = &mov_ops, },
81-
{ .name = "movzbl", .ops = &mov_ops, },
82-
{ .name = "movzwl", .ops = &mov_ops, },
83+
{ .name = "movzb", .ops = &mov_ops, },
84+
{ .name = "movzw", .ops = &mov_ops, },
85+
{ .name = "movzl", .ops = &mov_ops, },
8386
{ .name = "mulsd", .ops = &mov_ops, },
8487
{ .name = "mulss", .ops = &mov_ops, },
8588
{ .name = "nop", .ops = &nop_ops, },

0 commit comments

Comments
 (0)