Skip to content

Commit 5e8a5e8

Browse files
committed
Merge tag 'v6.6-rockchip-dtsfixes1' of git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip into arm/fixes
I2S pinctrl fixes, someone resurrected the rk3128 arm32 and found some needed fixes and finally some sound fixes for the px30 ringneck som. * tag 'v6.6-rockchip-dtsfixes1' of git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip: arm64: dts: rockchip: Fix i2s0 pin conflict on ROCK Pi 4 boards arm64: dts: rockchip: Add i2s0-2ch-bus-bclk-off pins to RK3399 ARM: dts: rockchip: Fix timer clocks for RK3128 ARM: dts: rockchip: Add missing quirk for RK3128's dma engine ARM: dts: rockchip: Add missing arm timer interrupt for RK3128 ARM: dts: rockchip: Fix i2c0 register address for RK3128 arm64: dts: rockchip: set codec system-clock-fixed on px30-ringneck-haikou arm64: dts: rockchip: use codec as clock master on px30-ringneck-haikou Link: https://lore.kernel.org/r/1965242.usQuhbGJ8B@phil Signed-off-by: Arnd Bergmann <[email protected]>
2 parents 759426c + 8cd79b7 commit 5e8a5e8

File tree

4 files changed

+27
-12
lines changed

4 files changed

+27
-12
lines changed

arch/arm/boot/dts/rockchip/rk3128.dtsi

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@
6464
compatible = "arm,armv7-timer";
6565
interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
6666
<GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
67-
<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
67+
<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
68+
<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
6869
arm,cpu-registers-not-fw-configured;
6970
clock-frequency = <24000000>;
7071
};
@@ -233,47 +234,47 @@
233234
compatible = "rockchip,rk3128-timer", "rockchip,rk3288-timer";
234235
reg = <0x20044000 0x20>;
235236
interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
236-
clocks = <&cru PCLK_TIMER>, <&xin24m>;
237+
clocks = <&cru PCLK_TIMER>, <&cru SCLK_TIMER0>;
237238
clock-names = "pclk", "timer";
238239
};
239240

240241
timer1: timer@20044020 {
241242
compatible = "rockchip,rk3128-timer", "rockchip,rk3288-timer";
242243
reg = <0x20044020 0x20>;
243244
interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
244-
clocks = <&cru PCLK_TIMER>, <&xin24m>;
245+
clocks = <&cru PCLK_TIMER>, <&cru SCLK_TIMER1>;
245246
clock-names = "pclk", "timer";
246247
};
247248

248249
timer2: timer@20044040 {
249250
compatible = "rockchip,rk3128-timer", "rockchip,rk3288-timer";
250251
reg = <0x20044040 0x20>;
251252
interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
252-
clocks = <&cru PCLK_TIMER>, <&xin24m>;
253+
clocks = <&cru PCLK_TIMER>, <&cru SCLK_TIMER2>;
253254
clock-names = "pclk", "timer";
254255
};
255256

256257
timer3: timer@20044060 {
257258
compatible = "rockchip,rk3128-timer", "rockchip,rk3288-timer";
258259
reg = <0x20044060 0x20>;
259260
interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
260-
clocks = <&cru PCLK_TIMER>, <&xin24m>;
261+
clocks = <&cru PCLK_TIMER>, <&cru SCLK_TIMER3>;
261262
clock-names = "pclk", "timer";
262263
};
263264

264265
timer4: timer@20044080 {
265266
compatible = "rockchip,rk3128-timer", "rockchip,rk3288-timer";
266267
reg = <0x20044080 0x20>;
267268
interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
268-
clocks = <&cru PCLK_TIMER>, <&xin24m>;
269+
clocks = <&cru PCLK_TIMER>, <&cru SCLK_TIMER4>;
269270
clock-names = "pclk", "timer";
270271
};
271272

272273
timer5: timer@200440a0 {
273274
compatible = "rockchip,rk3128-timer", "rockchip,rk3288-timer";
274275
reg = <0x200440a0 0x20>;
275276
interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
276-
clocks = <&cru PCLK_TIMER>, <&xin24m>;
277+
clocks = <&cru PCLK_TIMER>, <&cru SCLK_TIMER5>;
277278
clock-names = "pclk", "timer";
278279
};
279280

@@ -426,7 +427,7 @@
426427

427428
i2c0: i2c@20072000 {
428429
compatible = "rockchip,rk3128-i2c", "rockchip,rk3288-i2c";
429-
reg = <20072000 0x1000>;
430+
reg = <0x20072000 0x1000>;
430431
interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
431432
clock-names = "i2c";
432433
clocks = <&cru PCLK_I2C0>;
@@ -458,6 +459,7 @@
458459
interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
459460
<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
460461
arm,pl330-broken-no-flushp;
462+
arm,pl330-periph-burst;
461463
clocks = <&cru ACLK_DMAC>;
462464
clock-names = "apb_pclk";
463465
#dma-cells = <1>;

arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,17 @@
6868
simple-audio-card,format = "i2s";
6969
simple-audio-card,name = "Haikou,I2S-codec";
7070
simple-audio-card,mclk-fs = <512>;
71+
simple-audio-card,frame-master = <&sgtl5000_codec>;
72+
simple-audio-card,bitclock-master = <&sgtl5000_codec>;
7173

72-
simple-audio-card,codec {
73-
clocks = <&sgtl5000_clk>;
74+
sgtl5000_codec: simple-audio-card,codec {
7475
sound-dai = <&sgtl5000>;
76+
// Prevent the dai subsystem from overwriting the clock
77+
// frequency. We are using a fixed-frequency oscillator.
78+
system-clock-fixed;
7579
};
7680

7781
simple-audio-card,cpu {
78-
bitclock-master;
79-
frame-master;
8082
sound-dai = <&i2s0_8ch>;
8183
};
8284
};

arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,7 @@
492492

493493
&i2s0 {
494494
pinctrl-0 = <&i2s0_2ch_bus>;
495+
pinctrl-1 = <&i2s0_2ch_bus_bclk_off>;
495496
rockchip,capture-channels = <2>;
496497
rockchip,playback-channels = <2>;
497498
status = "okay";

arch/arm64/boot/dts/rockchip/rk3399.dtsi

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2457,6 +2457,16 @@
24572457
<4 RK_PA0 1 &pcfg_pull_none>;
24582458
};
24592459

2460+
i2s0_2ch_bus_bclk_off: i2s0-2ch-bus-bclk-off {
2461+
rockchip,pins =
2462+
<3 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>,
2463+
<3 RK_PD1 1 &pcfg_pull_none>,
2464+
<3 RK_PD2 1 &pcfg_pull_none>,
2465+
<3 RK_PD3 1 &pcfg_pull_none>,
2466+
<3 RK_PD7 1 &pcfg_pull_none>,
2467+
<4 RK_PA0 1 &pcfg_pull_none>;
2468+
};
2469+
24602470
i2s0_8ch_bus: i2s0-8ch-bus {
24612471
rockchip,pins =
24622472
<3 RK_PD0 1 &pcfg_pull_none>,

0 commit comments

Comments
 (0)