Skip to content

Commit 666d220

Browse files
james-c-linaronamhyung
authored andcommitted
perf tests: Fix "PE file support" test build
filename__read_build_id() now takes a blocking/non-blocking argument. The original behavior of filename__read_build_id() was blocking so add block=true to fix the build. Fixes: 2c369d9 ("perf symbol: Add blocking argument to filename__read_build_id") Signed-off-by: James Clark <[email protected]> Reviewed-by: Ian Rogers <[email protected]> Reviewed-by: Arnaldo Carvalho de Melo <[email protected]> Link: https://lore.kernel.org/r/20250903-james-perf-read-build-id-fix-v1-1-6a694d0a980f@linaro.org Signed-off-by: Namhyung Kim <[email protected]>
1 parent 01be43f commit 666d220

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/perf/tests/pe-file-parsing.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ static int run_dir(const char *d)
3737
size_t idx;
3838

3939
scnprintf(filename, PATH_MAX, "%s/pe-file.exe", d);
40-
ret = filename__read_build_id(filename, &bid);
40+
ret = filename__read_build_id(filename, &bid, /*block=*/true);
4141
TEST_ASSERT_VAL("Failed to read build_id",
4242
ret == sizeof(expect_build_id));
4343
TEST_ASSERT_VAL("Wrong build_id", !memcmp(bid.data, expect_build_id,
@@ -49,7 +49,7 @@ static int run_dir(const char *d)
4949
!strcmp(debuglink, expect_debuglink));
5050

5151
scnprintf(debugfile, PATH_MAX, "%s/%s", d, debuglink);
52-
ret = filename__read_build_id(debugfile, &bid);
52+
ret = filename__read_build_id(debugfile, &bid, /*block=*/true);
5353
TEST_ASSERT_VAL("Failed to read debug file build_id",
5454
ret == sizeof(expect_build_id));
5555
TEST_ASSERT_VAL("Wrong build_id", !memcmp(bid.data, expect_build_id,

0 commit comments

Comments
 (0)