Skip to content

Commit 70fb252

Browse files
AlanSterngregkh
authored andcommitted
USB: core: Update kerneldoc for usb_hcd_giveback_urb()
The kerneldoc added for usb_hcd_giveback_urb() by commit 41631d3 ("usb: core: Replace in_interrupt() in comments") is unclear and incorrect. Update the text for greater clarity and to say that URBs for a root hub will always use a BH context for their completion. Signed-off-by: Alan Stern <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent a381c6d commit 70fb252

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/usb/core/hcd.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1717,10 +1717,10 @@ static void usb_giveback_urb_bh(struct work_struct *work)
17171717
* @urb: urb being returned to the USB device driver.
17181718
* @status: completion status code for the URB.
17191719
*
1720-
* Context: atomic. The completion callback is invoked in caller's context.
1721-
* For HCDs with HCD_BH flag set, the completion callback is invoked in BH
1722-
* context (except for URBs submitted to the root hub which always complete in
1723-
* caller's context).
1720+
* Context: atomic. The completion callback is invoked either in a work queue
1721+
* (BH) context or in the caller's context, depending on whether the HCD_BH
1722+
* flag is set in the @hcd structure, except that URBs submitted to the
1723+
* root hub always complete in BH context.
17241724
*
17251725
* This hands the URB from HCD to its USB device driver, using its
17261726
* completion function. The HCD has freed all per-urb resources

0 commit comments

Comments
 (0)