Skip to content

Commit 84967de

Browse files
Minhong Hekuba-moo
authored andcommitted
ipv6: sr: validate HMAC algorithm ID in seg6_hmac_info_add
The seg6_genl_sethmac() directly uses the algorithm ID provided by the userspace without verifying whether it is an HMAC algorithm supported by the system. If an unsupported HMAC algorithm ID is configured, packets using SRv6 HMAC will be dropped during encapsulation or decapsulation. Fixes: 4f4853d ("ipv6: sr: implement API to control SR HMAC structure") Signed-off-by: Minhong He <[email protected]> Reviewed-by: Kuniyuki Iwashima <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 864e339 commit 84967de

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

net/ipv6/seg6_hmac.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,9 @@ int seg6_hmac_info_add(struct net *net, u32 key, struct seg6_hmac_info *hinfo)
304304
struct seg6_pernet_data *sdata = seg6_pernet(net);
305305
int err;
306306

307+
if (!__hmac_get_algo(hinfo->alg_id))
308+
return -EINVAL;
309+
307310
err = rhashtable_lookup_insert_fast(&sdata->hmac_infos, &hinfo->node,
308311
rht_params);
309312

0 commit comments

Comments
 (0)