Skip to content

Commit 88f9ee2

Browse files
jimcakpm00
authored andcommitted
kmemleak: drop (age <increasing>) from leak record
Patch series "tweak kmemleak report format". These 2 patches make minor changes to the report: 1st strips "age <increasing>" from output. This makes the output idempotent; unchanging until a new leak is reported. 2nd adds the backtrace.checksum to the "backtrace:" line. This lets a user see repeats without actually reading the whole backtrace. So now the backtrace line looks like this: backtrace (crc 603070071): I surveyed for un-wanted effects upon users: Syzkaller parses kmemleak in executor/common_linux.h: static void check_leaks(char** frames, int nframes) It just counts occurrences of "unreferenced object", specifically it does not look for "age", nor would it choke on "crc" being added. github has 3 repos with "kmemleak" mentioned, all are moribund. gitlab has 0 hits on "kmemleak". This patch (of 2): Displaying age is pretty, but counter-productive; it changes with current-time, so it surrenders idempotency of the output, which breaks simple hash-based cataloging of the records by the user. The trouble: sequential reads, wo new leaks, get new results: :#> sum /sys/kernel/debug/kmemleak 53439 74 /sys/kernel/debug/kmemleak :#> sum /sys/kernel/debug/kmemleak 59066 74 /sys/kernel/debug/kmemleak and age is why (nothing else changes): :#> grep -v age /sys/kernel/debug/kmemleak | sum 58894 67 :#> grep -v age /sys/kernel/debug/kmemleak | sum 58894 67 Since jiffies is already printed in the "comm" line, age adds nothing. Notably, syzkaller reads kmemleak only for "unreferenced object", and won't care about this reform of age-ism. A few moribund github repos mention it, but don't compile. Link: https://lkml.kernel.org/r/[email protected] Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Jim Cromie <[email protected]> Reviewed-by: Catalin Marinas <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent af7628d commit 88f9ee2

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

mm/kmemleak.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -355,14 +355,12 @@ static void print_unreferenced(struct seq_file *seq,
355355
int i;
356356
unsigned long *entries;
357357
unsigned int nr_entries;
358-
unsigned int msecs_age = jiffies_to_msecs(jiffies - object->jiffies);
359358

360359
nr_entries = stack_depot_fetch(object->trace_handle, &entries);
361360
warn_or_seq_printf(seq, "unreferenced object 0x%08lx (size %zu):\n",
362361
object->pointer, object->size);
363-
warn_or_seq_printf(seq, " comm \"%s\", pid %d, jiffies %lu (age %d.%03ds)\n",
364-
object->comm, object->pid, object->jiffies,
365-
msecs_age / 1000, msecs_age % 1000);
362+
warn_or_seq_printf(seq, " comm \"%s\", pid %d, jiffies %lu\n",
363+
object->comm, object->pid, object->jiffies);
366364
hex_dump_object(seq, object);
367365
warn_or_seq_printf(seq, " backtrace:\n");
368366

0 commit comments

Comments
 (0)