Skip to content

Commit 965c00e

Browse files
0x7f454c46Paolo Abeni
authored andcommitted
net/tcp: Limit TCP_AO_REPAIR to non-listen sockets
Listen socket is not an established TCP connection, so setsockopt(TCP_AO_REPAIR) doesn't have any impact. Restrict this uAPI for listen sockets. Fixes: faadfab ("net/tcp: Add TCP_AO_REPAIR") Signed-off-by: Dmitry Safonov <[email protected]> Reviewed-by: Eric Dumazet <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent da7dfaa commit 965c00e

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

net/ipv4/tcp.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3610,6 +3610,10 @@ int do_tcp_setsockopt(struct sock *sk, int level, int optname,
36103610
break;
36113611

36123612
case TCP_AO_REPAIR:
3613+
if (!tcp_can_repair_sock(sk)) {
3614+
err = -EPERM;
3615+
break;
3616+
}
36133617
err = tcp_ao_set_repair(sk, optval, optlen);
36143618
break;
36153619
#ifdef CONFIG_TCP_AO
@@ -4309,6 +4313,8 @@ int do_tcp_getsockopt(struct sock *sk, int level,
43094313
}
43104314
#endif
43114315
case TCP_AO_REPAIR:
4316+
if (!tcp_can_repair_sock(sk))
4317+
return -EPERM;
43124318
return tcp_ao_get_repair(sk, optval, optlen);
43134319
case TCP_AO_GET_KEYS:
43144320
case TCP_AO_INFO: {

0 commit comments

Comments
 (0)