Skip to content

Commit bd31394

Browse files
damien-lemoalmartinkpetersen
authored andcommitted
scsi: libsas: Make sas_get_ata_info() static
The function sas_get_ata_info() is used only in drivers/scsi/libsas/sas_ata.c. Remove its definition from include/scsi/sas_ata.h and make this function static. No functional changes. Signed-off-by: Damien Le Moal <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Johannes Thumshirn <[email protected]> Reviewed-by: John Garry <[email protected]> Reviewed-by: Jason Yan <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 0dd0357 commit bd31394

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

drivers/scsi/libsas/sas_ata.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ static int sas_get_ata_command_set(struct domain_device *dev)
252252
return ata_dev_classify(&tf);
253253
}
254254

255-
int sas_get_ata_info(struct domain_device *dev, struct ex_phy *phy)
255+
static int sas_get_ata_info(struct domain_device *dev, struct ex_phy *phy)
256256
{
257257
if (phy->attached_tproto & SAS_PROTOCOL_STP)
258258
dev->tproto = phy->attached_tproto;

include/scsi/sas_ata.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ static inline bool dev_is_sata(struct domain_device *dev)
2828
}
2929
}
3030

31-
int sas_get_ata_info(struct domain_device *dev, struct ex_phy *phy);
3231
int sas_ata_init(struct domain_device *dev);
3332
void sas_ata_task_abort(struct sas_task *task);
3433
void sas_ata_strategy_handler(struct Scsi_Host *shost);
@@ -96,11 +95,6 @@ static inline void sas_resume_sata(struct asd_sas_port *port)
9695
{
9796
}
9897

99-
static inline int sas_get_ata_info(struct domain_device *dev, struct ex_phy *phy)
100-
{
101-
return 0;
102-
}
103-
10498
static inline void sas_ata_end_eh(struct ata_port *ap)
10599
{
106100
}

0 commit comments

Comments
 (0)