net/mlx5: Fix a NULL vs IS_ERR() check

Dan Carpenter · Saeed Mahameed · commit ca4ef28d0ad8 · 2023-12-04T22:11:54.000-08:00
The mlx5_esw_offloads_devlink_port() function returns error pointers, not NULL. Fixes: 7bef147 ("net/mlx5: Don't skip vport check") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -1497,7 +1497,7 @@ mlx5e_vport_vf_rep_load(struct mlx5_core_dev *dev, struct mlx5_eswitch_rep *rep)
 
 	dl_port = mlx5_esw_offloads_devlink_port(dev->priv.eswitch,
 						 rpriv->rep->vport);
-	if (dl_port) {
+	if (!IS_ERR(dl_port)) {
 		SET_NETDEV_DEVLINK_PORT(netdev, dl_port);
 		mlx5e_rep_vnic_reporter_create(priv, dl_port);
 	}

Original file line number	Diff line number	Diff line change
`@@ -1497,7 +1497,7 @@ mlx5e_vport_vf_rep_load(struct mlx5_core_dev dev, struct mlx5_eswitch_rep rep)`
`1497`	`1497`
`1498`	`1498`	`dl_port = mlx5_esw_offloads_devlink_port(dev->priv.eswitch,`
`1499`	`1499`	`rpriv->rep->vport);`
`1500`		`- if (dl_port) {`
	`1500`	`+ if (!IS_ERR(dl_port)) {`
`1501`	`1501`	`SET_NETDEV_DEVLINK_PORT(netdev, dl_port);`
`1502`	`1502`	`mlx5e_rep_vnic_reporter_create(priv, dl_port);`
`1503`	`1503`	`}`