Skip to content

Commit e5203d8

Browse files
bvanasschemartinkpetersen
authored andcommitted
scsi: ufs: core: Remove WARN_ON_ONCE() call from ufshcd_uic_cmd_compl()
The UIC completion interrupt may be disabled while an UIC command is being processed. When the UIC completion interrupt is reenabled, an UIC interrupt is triggered and the WARN_ON_ONCE(!cmd) statement is hit. Hence this patch that removes this kernel warning. Fixes: fcd8b04 ("scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to analyze") Reviewed-by: Peter Wang <[email protected]> Signed-off-by: Bart Van Assche <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin K. Petersen <[email protected]>
1 parent eabcac8 commit e5203d8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/ufs/core/ufshcd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5561,7 +5561,7 @@ static irqreturn_t ufshcd_uic_cmd_compl(struct ufs_hba *hba, u32 intr_status)
55615561

55625562
guard(spinlock_irqsave)(hba->host->host_lock);
55635563
cmd = hba->active_uic_cmd;
5564-
if (WARN_ON_ONCE(!cmd))
5564+
if (!cmd)
55655565
goto unlock;
55665566

55675567
if (ufshcd_is_auto_hibern8_error(hba, intr_status))

0 commit comments

Comments
 (0)