Skip to content

Commit 8f2fcff

Browse files
malibertymaliberty
authored
Merge pull request The-OpenROAD-Project#3407 from The-OpenROAD-Project-staging/fix_ant_vars
add description and default values for max iterations of repair antennas
2 parents 272f9de + 383bdfb commit 8f2fcff

File tree

11 files changed

+29
-27
lines changed

11 files changed

+29
-27
lines changed

‎docs/user/FlowVariables.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,8 @@ configuration file.
163163
| <a name="MACRO_WRAPPERS"></a>MACRO_WRAPPERS| The wrapper file that replaces existing macros with their wrapped version.| |
164164
| <a name="MAKE_TRACKS"></a>MAKE_TRACKS| Tcl file that defines add routing tracks to a floorplan.| |
165165
| <a name="MATCH_CELL_FOOTPRINT"></a>MATCH_CELL_FOOTPRINT| Enforce sizing operations to only swap cells that have the same layout boundary.| 0|
166+
| <a name="MAX_REPAIR_ANTENNAS_ITER_DRT"></a>MAX_REPAIR_ANTENNAS_ITER_DRT| Defines the maximum number of iterations post-detailed routing repair antennas will run.| 5|
167+
| <a name="MAX_REPAIR_ANTENNAS_ITER_GRT"></a>MAX_REPAIR_ANTENNAS_ITER_GRT| Defines the maximum number of iterations post global routing repair antennas will run.| 5|
166168
| <a name="MAX_ROUTING_LAYER"></a>MAX_ROUTING_LAYER| The highest metal layer name to be used in routing.| |
167169
| <a name="MIN_BUF_CELL_AND_PORTS"></a>MIN_BUF_CELL_AND_PORTS| Used to insert a buffer cell to pass through wires. Used in synthesis.| |
168170
| <a name="MIN_ROUTING_LAYER"></a>MIN_ROUTING_LAYER| The lowest metal layer name to be used in routing.| |
@@ -390,6 +392,7 @@ configuration file.
390392
- [DETAILED_METRICS](#DETAILED_METRICS)
391393
- [GLOBAL_ROUTE_ARGS](#GLOBAL_ROUTE_ARGS)
392394
- [HOLD_SLACK_MARGIN](#HOLD_SLACK_MARGIN)
395+
- [MAX_REPAIR_ANTENNAS_ITER_GRT](#MAX_REPAIR_ANTENNAS_ITER_GRT)
393396
- [MAX_ROUTING_LAYER](#MAX_ROUTING_LAYER)
394397
- [MIN_ROUTING_LAYER](#MIN_ROUTING_LAYER)
395398
- [PRE_GLOBAL_ROUTE_TCL](#PRE_GLOBAL_ROUTE_TCL)
@@ -410,6 +413,7 @@ configuration file.
410413
- [DETAILED_ROUTE_END_ITERATION](#DETAILED_ROUTE_END_ITERATION)
411414
- [FILL_CELLS](#FILL_CELLS)
412415
- [MATCH_CELL_FOOTPRINT](#MATCH_CELL_FOOTPRINT)
416+
- [MAX_REPAIR_ANTENNAS_ITER_DRT](#MAX_REPAIR_ANTENNAS_ITER_DRT)
413417
- [MAX_ROUTING_LAYER](#MAX_ROUTING_LAYER)
414418
- [MIN_ROUTING_LAYER](#MIN_ROUTING_LAYER)
415419
- [REPORT_CLOCK_SKEW](#REPORT_CLOCK_SKEW)

‎flow/platforms/asap7/config.mk‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,6 @@ export MIN_ROUTING_LAYER ?= M2
6868
export MIN_CLK_ROUTING_LAYER ?= M4
6969
export MAX_ROUTING_LAYER ?= M7
7070

71-
# Max iterations of repair antennas
72-
export MAX_REPAIR_ANTENNAS_ITER_GRT ?= 5
73-
export MAX_REPAIR_ANTENNAS_ITER_DRT ?= 5
74-
7571
# Define fastRoute tcl
7672
export FASTROUTE_TCL ?= $(PLATFORM_DIR)/fastroute.tcl
7773

‎flow/platforms/gf180/config.mk‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,6 @@ export MIN_ROUTING_LAYER ?= Metal2
9393
export MAX_ROUTING_LAYER ?= Metal5
9494
export DISABLE_VIA_GEN ?= 1
9595

96-
# Max iterations of repair antennas
97-
export MAX_REPAIR_ANTENNAS_ITER_GRT ?= 5
98-
export MAX_REPAIR_ANTENNAS_ITER_DRT ?= 5
99-
10096
# Define fastRoute tcl
10197
export FASTROUTE_TCL ?= $(PLATFORM_DIR)/fastroute.tcl
10298

‎flow/platforms/ihp-sg13g2/config.mk‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,6 @@ export MAX_ROUTING_LAYER ?= Metal5
116116
#export VIA_IN_PIN_MAX_LAYER ?= Metal1
117117
#export DISABLE_VIA_GEN ?= 1
118118

119-
# Max iterations of repair antennas
120-
export MAX_REPAIR_ANTENNAS_ITER_GRT ?= 5
121-
export MAX_REPAIR_ANTENNAS_ITER_DRT ?= 5
122-
123119
# Define fastRoute tcl
124120
export FASTROUTE_TCL ?= $(PLATFORM_DIR)/fastroute.tcl
125121

‎flow/platforms/nangate45/config.mk‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,6 @@ export MIN_ROUTING_LAYER = metal2
7575
export MIN_CLK_ROUTING_LAYER = metal4
7676
export MAX_ROUTING_LAYER = metal10
7777

78-
# Max iterations of repair antennas
79-
export MAX_REPAIR_ANTENNAS_ITER_GRT ?= 5
80-
export MAX_REPAIR_ANTENNAS_ITER_DRT ?= 5
81-
8278
# Define fastRoute tcl
8379
export FASTROUTE_TCL ?= $(PLATFORM_DIR)/fastroute.tcl
8480

‎flow/platforms/sky130hd/config.mk‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,7 @@ export PLACE_DENSITY ?= 0.60
117117
export MIN_ROUTING_LAYER ?= met1
118118
export MIN_CLK_ROUTING_LAYER ?= met3
119119
export MAX_ROUTING_LAYER ?= met5
120-
#
121-
# Max iterations of repair antennas
122-
export MAX_REPAIR_ANTENNAS_ITER_GRT ?= 5
123-
export MAX_REPAIR_ANTENNAS_ITER_DRT ?= 5
120+
124121
#
125122
# Define fastRoute tcl
126123
export FASTROUTE_TCL ?= $(PLATFORM_DIR)/fastroute.tcl

‎flow/platforms/sky130hs/config.mk‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,7 @@ export PLACE_DENSITY ?= 0.50
7979
export MIN_ROUTING_LAYER = met1
8080
export MIN_CLK_ROUTING_LAYER = met3
8181
export MAX_ROUTING_LAYER = met5
82-
#
83-
# Max iterations of repair antennas
84-
export MAX_REPAIR_ANTENNAS_ITER_GRT ?= 5
85-
export MAX_REPAIR_ANTENNAS_ITER_DRT ?= 5
82+
8683
#
8784
# Define fastRoute tcl
8885
export FASTROUTE_TCL ?= $(PLATFORM_DIR)/fastroute.tcl

‎flow/scripts/detail_route.tcl‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,10 @@ set all_args [concat [list \
5252

5353
log_cmd detailed_route {*}$all_args
5454

55-
if { ![env_var_equals SKIP_ANTENNA_REPAIR_POST_DRT 1] && $::env(MAX_REPAIR_ANTENNAS_ITER_DRT) } {
55+
if {
56+
![env_var_equals SKIP_ANTENNA_REPAIR_POST_DRT 1] &&
57+
[env_var_exists_and_non_empty MAX_REPAIR_ANTENNAS_ITER_DRT]
58+
} {
5659
set repair_antennas_iters 1
5760
if { [repair_antennas] } {
5861
detailed_route {*}$all_args

‎flow/scripts/global_route.tcl‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,10 @@ proc global_route_helper { } {
8686
log_cmd global_route -end_incremental \
8787
-congestion_report_file $::env(REPORTS_DIR)/congestion_post_recover_power.rpt
8888

89-
if { ![env_var_equals SKIP_ANTENNA_REPAIR 1] && $::env(MAX_REPAIR_ANTENNAS_ITER_GRT) } {
89+
if {
90+
![env_var_equals SKIP_ANTENNA_REPAIR 1] &&
91+
[env_var_exists_and_non_empty MAX_REPAIR_ANTENNAS_ITER_GRT]
92+
} {
9093
puts "Repair antennas..."
9194
repair_antennas -iterations $::env(MAX_REPAIR_ANTENNAS_ITER_GRT)
9295
check_placement -verbose

‎flow/scripts/variables.yaml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1013,3 +1013,17 @@ SKIP_DETAILED_ROUTE:
10131013
stages:
10141014
- route
10151015
- final
1016+
MAX_REPAIR_ANTENNAS_ITER_DRT:
1017+
default: 5
1018+
description: >
1019+
Defines the maximum number of iterations post-detailed routing repair
1020+
antennas will run.
1021+
stages:
1022+
- route
1023+
MAX_REPAIR_ANTENNAS_ITER_GRT:
1024+
default: 5
1025+
description: >
1026+
Defines the maximum number of iterations post global routing repair
1027+
antennas will run.
1028+
stages:
1029+
- grt

0 commit comments

Comments
 (0)