remove read_macro_placement and use MPL commands instead

Signed-off-by: Arthur Koucher <[email protected]>

Author: AcKoucher

docs/user/FlowVariables.md

@@ -155,7 +155,6 @@ configuration file.
 | <a name="LIB_FILES"></a>LIB_FILES| A Liberty file of the standard cell library with PVT characterization, input and output characteristics, timing and power definitions for each cell.| |
 | <a name="MACRO_BLOCKAGE_HALO"></a>MACRO_BLOCKAGE_HALO| Distance beyond the edges of a macro that will also be covered by the blockage generated for that macro. Note that the default macro blockage halo comes from the largest of the specified MACRO_PLACE_HALO x or y values. This variable overrides that calculation.| |
 | <a name="MACRO_EXTENSION"></a>MACRO_EXTENSION| Sets the number of GCells added to the blockages boundaries from macros.| |
-| <a name="MACRO_PLACEMENT"></a>MACRO_PLACEMENT| Specifies the path of a file on how to place certain macros manually using read_macro_placement.| |
 | <a name="MACRO_PLACEMENT_TCL"></a>MACRO_PLACEMENT_TCL| Specifies the path of a TCL file on how to place certain macros manually.| |
 | <a name="MACRO_PLACE_HALO"></a>MACRO_PLACE_HALO| Horizontal/vertical halo around macros (microns). Used by automatic macro placement.| |
 | <a name="MACRO_ROWS_HALO_X"></a>MACRO_ROWS_HALO_X| Horizontal distance between the edge of the macro and the beginning of the rows created by tapcell. Only available for ASAP7 PDK and GF180/uart-blocks design.| |
@@ -299,7 +298,6 @@ configuration file.
 - [HOLD_SLACK_MARGIN](#HOLD_SLACK_MARGIN)
 - [IO_CONSTRAINTS](#IO_CONSTRAINTS)
 - [MACRO_BLOCKAGE_HALO](#MACRO_BLOCKAGE_HALO)
-- [MACRO_PLACEMENT](#MACRO_PLACEMENT)
 - [MACRO_PLACEMENT_TCL](#MACRO_PLACEMENT_TCL)
 - [MACRO_PLACE_HALO](#MACRO_PLACE_HALO)
 - [MACRO_ROWS_HALO_X](#MACRO_ROWS_HALO_X)

flow/designs/sky130hd/chameleon/chameleon.macro_placment.cfg

@@ -44,7 +44,7 @@ export ADDITIONAL_LEFS  = $(chameleon_DIR)/lef/apb_sys_0.lef \
                           $(chameleon_DIR)/lef/DMC_32x16HC.lef \
                           $(chameleon_DIR)/lef/ibex_wrapper.lef
 
-export MACRO_PLACEMENT = $(chameleon_DIR)/chameleon.macro_placment.cfg
+export MACRO_PLACEMENT_TCL = $(chameleon_DIR)/macro_placement.tcl
 
 export FP_PDN_RAIL_WIDTH  = 0.48
 export FP_PDN_RAIL_OFFSET = 0

flow/designs/sky130hd/chameleon/config.mk

@@ -0,0 +1,6 @@
+place_macro -macro_name {RAM.genblk1\[0\].RAM} -location {200 150} -orientation R0
+place_macro -macro_name {RAM.genblk1\[1\].RAM} -location {1600 150} -orientation R0
+place_macro -macro_name {RAM.genblk1\[2\].RAM} -location {200 1950} -orientation R180
+place_macro -macro_name {ahb_sys_0_uut.S0.CACHE} -location {2100 2650} -orientation R0
+place_macro -macro_name {ahb_sys_0_uut.apb_sys_inst_0} -location {1470 2643} -orientation R0
+place_macro -macro_name {ibex_core} -location {2150 1700} -orientation R0

flow/designs/sky130hd/chameleon/macro_placement.tcl

@@ -36,9 +36,6 @@ if { [find_macros] != "" } {
 
   if { [env_var_exists_and_non_empty MACRO_PLACEMENT_TCL] } {
     log_cmd source $::env(MACRO_PLACEMENT_TCL)
-  } elseif { [env_var_exists_and_non_empty MACRO_PLACEMENT] } {
-    source $::env(SCRIPTS_DIR)/read_macro_placement.tcl
-    log_cmd read_macro_placement $::env(MACRO_PLACEMENT)
   } else {
     set additional_rtlmp_args ""
     append_env_var additional_rtlmp_args RTLMP_MAX_LEVEL -max_num_level 1

flow/scripts/macro_place_util.tcl

@@ -341,12 +341,6 @@ TAPCELL_TCL:
     Path to Endcap and Welltie cells file.
   stages:
     - floorplan
-MACRO_PLACEMENT:
-  description: >
-    Specifies the path of a file on how to place certain macros manually using
-    read_macro_placement.
-  stages:
-    - floorplan
 MACRO_PLACEMENT_TCL:
   description: |
     Specifies the path of a TCL file on how to place certain macros manually.

flow/scripts/read_macro_placement.tcl

@@ -12,7 +12,7 @@ ISSUE_CP_DESIGN_FILE_VARS="SDC_FILE \
                            FOOTPRINT \
                            SIG_MAP_FILE \
                            IO_CONSTRAINTS \
-                           MACRO_PLACEMENT \
+                           MACRO_PLACEMENT_TCL \
                            MACRO_WRAPPERS \
                            RTLMP_CONFIG_FILE \
                            DFF_LIB_FILE "