[AMDGPU] Fix -Wpessimizing-move in AMDGPUSwLowerLDS.cpp (NFC)

DamonFool · DamonFool · commit dff3c9614144 · 2024-08-26T11:38:40.000+08:00
/llvm-project/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp:260:10:
error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
  return std::move(OrderedKernels);
         ^
/llvm-project/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp:260:10: note: remove std::move call here
  return std::move(OrderedKernels);
         ^~~~~~~~~~              ~
1 error generated.
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp b/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp
@@ -257,7 +257,7 @@ SetVector<Function *> AMDGPUSwLowerLDS::getOrderedIndirectLDSAccessingKernels(
     Func->setMetadata("llvm.amdgcn.lds.kernel.id",
                       MDNode::get(Ctx, AttrMDArgs));
   }
-  return std::move(OrderedKernels);
+  return OrderedKernels;
 }
 
 void AMDGPUSwLowerLDS::getNonKernelsWithLDSArguments(const CallGraph &CG) {

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,7 @@ SetVector<Function *> AMDGPUSwLowerLDS::getOrderedIndirectLDSAccessingKernels(`
`257`	`257`	`Func->setMetadata("llvm.amdgcn.lds.kernel.id",`
`258`	`258`	`MDNode::get(Ctx, AttrMDArgs));`
`259`	`259`	`}`
`260`		`- return std::move(OrderedKernels);`
	`260`	`+ return OrderedKernels;`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`void AMDGPUSwLowerLDS::getNonKernelsWithLDSArguments(const CallGraph &CG) {`