Fix style offenses

Author: ashmaroli

.rubocop.yml

@@ -9,23 +9,14 @@ AllCops:
   TargetRubyVersion: 2.7
   SuggestExtensions: false
 
-Lint/ShadowingOuterLocalVariable:
+Layout/LineLength:
   Exclude:
     - lib/jekyll-archives.rb
-
-# Remove once Jekyll core has dropped explicit support for Ruby 2.2
-Lint/SafeNavigationConsistency:
-  Exclude:
     - lib/jekyll-archives/archive.rb
-
-Metrics/BlockLength:
-  Exclude:
     - test/**/*.rb
 
-Metrics/LineLength:
+Metrics/BlockLength:
   Exclude:
-    - lib/jekyll-archives.rb
-    - lib/jekyll-archives/archive.rb
     - test/**/*.rb
 
 Minitest/AssertKindOf:

lib/jekyll-archives.rb

@@ -133,7 +133,7 @@ def append_enabled_date_type(meta, type, posts)
       def date_attr_hash(posts, id)
         hash = Hash.new { |hsh, key| hsh[key] = [] }
         posts.each { |post| hash[post.date.strftime(id)] << post }
-        hash.each_value { |posts| posts.sort!.reverse! }
+        hash.each_value { |posts_in_hsh| posts_in_hsh.sort!.reverse! }
         hash
       end
     end

lib/jekyll-archives/archive.rb

@@ -77,19 +77,19 @@ def url
           :permalink    => nil
         ).to_s
       rescue ArgumentError
-        raise ArgumentError, "Template \"#{template}\" provided is invalid."
+        raise ArgumentError, "Template #{template.inspect} provided is invalid."
       end
 
       def permalink
-        data&.is_a?(Hash) && data["permalink"]
+        data.is_a?(Hash) && data["permalink"]
       end
 
       # Produce a title object suitable for Liquid based on type of archive.
       #
       # Returns a String (for tag and category archives) and nil for
       # date-based archives.
       def title
-        @title if @title.is_a? String
+        @title if @title.is_a?(String)
       end
 
       # Produce a date object if a date-based archive

script/fmt

@@ -1,8 +1,8 @@
 #!/bin/bash
 set -e
 
-echo "Rubocop $(bundle exec rubocop --version)"
-bundle exec rubocop -S -D -E $@
+echo "RuboCop $(bundle exec rubocop --version)"
+bundle exec rubocop -E --disable-pending-cops $@
 success=$?
 if ((success != 0)); then
    echo -e "\nTry running \`script/fmt -a\` to automatically fix errors"