Add option to not advertise software codecs as supported

Sometimes, software-codecs can cause performance-related issues like
seen in #4838. The added option allows disabling software codecs,
forcing a transcode to a non-software/hardware-accelerated codec.

Author: luca-schlecker

app/src/main/java/org/jellyfin/androidtv/preference/UserPreferences.kt

@@ -236,6 +236,11 @@ class UserPreferences(context: Context) : SharedPreferenceStore(
   		 * Enable PGS subtitle direct-play.
 		 */
 		var pgsDirectPlay = booleanPreference("pgs_enabled", true)
+
+		/**
+		 * Enable the use of software-based codecs.
+		 */
+		var useSoftwareCodecs = booleanPreference("use_software_codecs", true)
 	}
 
 	init {

app/src/main/java/org/jellyfin/androidtv/ui/settings/screen/playback/SettingsPlaybackAdvancedScreen.kt

@@ -185,6 +185,16 @@ fun SettingsPlaybackAdvancedScreen() {
 			)
 		}
 
+		item {
+			var useSoftwareCodecs by rememberPreference(userPreferences, UserPreferences.useSoftwareCodecs)
+
+			ListButton(
+				headingContent = { Text(stringResource(R.string.pref_use_software_codecs)) },
+				trailingContent = { Checkbox(checked = useSoftwareCodecs) },
+				onClick = { useSoftwareCodecs = !useSoftwareCodecs }
+			)
+		}
+
 		item { ListSection(headingContent = { Text(stringResource(R.string.pref_live_tv_cat)) }) }
 
 		item {

app/src/main/java/org/jellyfin/androidtv/util/profile/MediaCodecCapabilitiesTest.kt

@@ -1,6 +1,7 @@
 package org.jellyfin.androidtv.util.profile
 
 import android.content.Context
+import android.media.MediaCodecInfo
 import android.media.MediaCodecInfo.CodecProfileLevel
 import android.media.MediaCodecList
 import android.media.MediaFormat
@@ -15,6 +16,7 @@ class MediaCodecCapabilitiesTest(
 ) {
 	private val display by lazy { ContextCompat.getDisplayOrDefault(context) }
 	private val mediaCodecList by lazy { MediaCodecList(MediaCodecList.REGULAR_CODECS) }
+	var useSoftwareCodecs = true
 
 	// Map common Dolby Vision Profiles to their corresponding CodecProfileLevel constant
 	private object DolbyVisionProfiles {
@@ -207,6 +209,7 @@ class MediaCodecCapabilitiesTest(
 
 		for (info in mediaCodecList.codecInfos) {
 			if (info.isEncoder) continue
+			if (!useSoftwareCodecs && info.isSoftwareCodec()) continue
 
 			try {
 				val capabilities = info.getCapabilitiesForType(mime)
@@ -226,6 +229,7 @@ class MediaCodecCapabilitiesTest(
 	private fun hasDecoder(mime: String, profile: Int, level: Int): Boolean {
 		for (info in mediaCodecList.codecInfos) {
 			if (info.isEncoder) continue
+			if (!useSoftwareCodecs && info.isSoftwareCodec()) continue
 
 			try {
 				val capabilities = info.getCapabilitiesForType(mime)
@@ -253,6 +257,7 @@ class MediaCodecCapabilitiesTest(
 	private fun hasCodecForMime(mime: String): Boolean {
 		for (info in mediaCodecList.codecInfos) {
 			if (info.isEncoder) continue
+			if (!useSoftwareCodecs && info.isSoftwareCodec()) continue
 
 			if (info.supportedTypes.any { it.equals(mime, ignoreCase = true) }) {
 				Timber.i("found codec %s for mime %s", info.name, mime)
@@ -268,6 +273,7 @@ class MediaCodecCapabilitiesTest(
 
 		for (info in mediaCodecList.codecInfos) {
 			if (info.isEncoder) continue
+			if (!useSoftwareCodecs && info.isSoftwareCodec()) continue
 
 			try {
 				val types = info.getSupportedTypes()
@@ -289,6 +295,7 @@ class MediaCodecCapabilitiesTest(
 
 		for (info in mediaCodecList.codecInfos) {
 			if (info.isEncoder) continue
+			if (!useSoftwareCodecs && info.isSoftwareCodec()) continue
 
 			try {
 				val capabilities = info.getCapabilitiesForType(mime)
@@ -308,4 +315,16 @@ class MediaCodecCapabilitiesTest(
 
 		return Size(maxWidth, maxHeight)
 	}
+
+	private fun MediaCodecInfo.isSoftwareCodec(): Boolean {
+		return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+			this.isSoftwareOnly
+		} else {
+			val name = this.name
+
+			// detect software-based codecs by name; approach taken from here:
+			// https://android.googlesource.com/platform/frameworks/av/+/d5dbc2b31c492be23fc4d4a96619330b63499b06/media/libstagefright/MediaCodecList.cpp#364
+			name.startsWith("OMX.google.", ignoreCase = true) || name.startsWith("c2.android.", ignoreCase = true)
+		}
+	}
 }

app/src/main/java/org/jellyfin/androidtv/util/profile/deviceProfile.kt

@@ -85,6 +85,7 @@ fun createDeviceProfile(
 	downMixAudio = userPreferences[UserPreferences.audioBehaviour] == AudioBehavior.DOWNMIX_TO_STEREO,
 	assDirectPlay = false,
 	pgsDirectPlay = userPreferences[UserPreferences.pgsDirectPlay],
+	useSoftwareCodecs = userPreferences[UserPreferences.useSoftwareCodecs],
 )
 
 fun createDeviceProfile(
@@ -94,7 +95,10 @@ fun createDeviceProfile(
 	downMixAudio: Boolean,
 	assDirectPlay: Boolean,
 	pgsDirectPlay: Boolean,
+	useSoftwareCodecs: Boolean,
 ) = buildDeviceProfile {
+	mediaTest.useSoftwareCodecs = useSoftwareCodecs
+
 	val allowedAudioCodecs = when {
 		downMixAudio -> downmixSupportedAudioCodecs
 		!isAC3Enabled -> supportedAudioCodecs.filterNot { it == Codec.Audio.EAC3 || it == Codec.Audio.AC3 }.toTypedArray()

app/src/main/res/values-de/strings.xml

@@ -621,4 +621,5 @@
     <string name="video_player_internal">Eingebauter Videoplayer</string>
     <string name="video_player_external">Externe App</string>
     <string name="filters">Filter</string>
+    <string name="pref_use_software_codecs">Software-Codecs verwenden</string>
 </resources>

app/src/main/res/values-en-rGB/strings.xml

@@ -621,4 +621,5 @@
     <string name="video_player_external">External app</string>
     <string name="playback_video_player_external_empty">You don\'t have any video player apps installed on your device that can open Jellyfin videos.</string>
     <string name="filters">Filters</string>
+    <string name="pref_use_software_codecs">Use software codecs</string>
 </resources>

app/src/main/res/values/strings.xml

@@ -621,4 +621,5 @@
         <item quantity="one">%1$s album</item>
         <item quantity="other">%1$s albums</item>
     </plurals>
+    <string name="pref_use_software_codecs">Use software codecs</string>
 </resources>