Hide warnings

Author: jelmer

dulwich/client.py

@@ -1478,12 +1478,7 @@ def archive(
 
     @staticmethod
     def _warn_filter_objects() -> None:
-        import warnings
-
-        warnings.warn(
-            "object filtering not recognized by server, ignoring",
-            UserWarning,
-        )
+        logging.warning("object filtering not recognized by server, ignoring")
 
 
 def check_wants(wants: Set[bytes], refs: Mapping[bytes, bytes]) -> None:

dulwich/signature.py

@@ -1293,12 +1293,13 @@ def verify(self, data: bytes, signature: bytes) -> None:
                 args.extend(["-r", self.revocation_file])
 
             try:
-                subprocess.run(
-                    args,
-                    stdin=open(data_filename, "rb"),
-                    capture_output=True,
-                    check=True,
-                )
+                with open(data_filename, "rb") as data_file:
+                    subprocess.run(
+                        args,
+                        stdin=data_file,
+                        capture_output=True,
+                        check=True,
+                    )
             except subprocess.CalledProcessError as e:
                 raise BadSignature(
                     f"SSH signature verification failed: {e.stderr.decode('utf-8', errors='replace')}"

tests/compat/test_partial_clone.py

@@ -390,14 +390,15 @@ def determine_wants(refs, depth=None):
             # Get all refs
             return list(refs.values())
 
-        # Fetch with filter
-        result = client.fetch(
-            path,
-            dest_repo,
-            determine_wants=determine_wants,
-            progress=None,
-            filter_spec=b"blob:none",
-        )
+        # Fetch with filter (may warn if server doesn't support filtering)
+        with self.assertLogs(level="WARNING"):
+            result = client.fetch(
+                path,
+                dest_repo,
+                determine_wants=determine_wants,
+                progress=None,
+                filter_spec=b"blob:none",
+            )
 
         # The fetch should succeed with partial clone
         self.assertIsNotNone(result)
@@ -430,13 +431,14 @@ def test_clone_with_filter(self) -> None:
 
         client, path = get_transport_and_path(f"git://localhost:{daemon_port}/")
 
-        # Clone with blob:limit filter
-        cloned_repo = client.clone(
-            path,
-            dest_path,
-            mkdir=False,
-            filter_spec=b"blob:limit=100",
-        )
+        # Clone with blob:limit filter (may warn if server doesn't support filtering)
+        with self.assertLogs(level="WARNING"):
+            cloned_repo = client.clone(
+                path,
+                dest_path,
+                mkdir=False,
+                filter_spec=b"blob:limit=100",
+            )
         self.addCleanup(cloned_repo.close)
 
         # Verify clone succeeded
@@ -483,6 +485,11 @@ def _start_git_daemon(self, repo_path):
         def cleanup_daemon():
             daemon_process.terminate()
             daemon_process.wait(timeout=2)
+            # Close pipes to avoid ResourceWarning
+            if daemon_process.stdout:
+                daemon_process.stdout.close()
+            if daemon_process.stderr:
+                daemon_process.stderr.close()
 
         self.addCleanup(cleanup_daemon)
 

tests/porcelain/test_ignore.py

@@ -59,14 +59,10 @@ def test_quote_path_true_unicode_filenames(self) -> None:
 
         # Test with quote_path=True (default)
         abs_paths = [os.path.join(self.test_dir, f) for f in test_files]
-        ignored_quoted = set(
-            check_ignore(self.test_dir, abs_paths, quote_path=True)
-        )
+        ignored_quoted = set(check_ignore(self.test_dir, abs_paths, quote_path=True))
 
         # Test with quote_path=False
-        ignored_unquoted = set(
-            check_ignore(self.test_dir, abs_paths, quote_path=False)
-        )
+        ignored_unquoted = set(check_ignore(self.test_dir, abs_paths, quote_path=False))
 
         # Verify quoted results
         expected_quoted = {
@@ -100,12 +96,8 @@ def test_quote_path_ascii_filenames(self) -> None:
 
         # Test both settings
         abs_paths = [os.path.join(self.test_dir, f) for f in test_files]
-        ignored_quoted = set(
-            check_ignore(self.test_dir, abs_paths, quote_path=True)
-        )
-        ignored_unquoted = set(
-            check_ignore(self.test_dir, abs_paths, quote_path=False)
-        )
+        ignored_quoted = set(check_ignore(self.test_dir, abs_paths, quote_path=True))
+        ignored_unquoted = set(check_ignore(self.test_dir, abs_paths, quote_path=False))
 
         # Both should return the same results for ASCII filenames
         expected = {"test.txt", "file.tmp"}

tests/porcelain/test_lfs.py

@@ -276,8 +276,9 @@ def test_clone_with_builtin_lfs_no_config(self):
         with self.assertRaises(KeyError):
             config.get((b"filter", b"lfs"), b"smudge")
 
-        # Clone the repository
-        cloned_repo = porcelain.clone(source_dir, clone_dir)
+        # Clone the repository (may warn about missing LFS objects)
+        with self.assertLogs("dulwich.lfs", level="WARNING"):
+            cloned_repo = porcelain.clone(source_dir, clone_dir)
 
         # Verify that built-in LFS filter was used
         normalizer = cloned_repo.get_blob_normalizer()

tests/test_annotate.py

@@ -18,9 +18,7 @@
 
 """Tests for annotate support."""
 
-import os
 import tempfile
-import unittest
 from typing import Any
 from unittest import TestCase
 

tests/test_bisect.py

@@ -26,7 +26,6 @@
 import tempfile
 
 from dulwich.bisect import BisectState
-from dulwich.objects import Tree
 from dulwich.repo import Repo
 from dulwich.tests.utils import make_commit
 

tests/test_filters.py

@@ -385,7 +385,8 @@ def test_optional_filter_failure_fallback(self) -> None:
             f.write(b"test content\n")
 
         # Adding file should work and fallback to original content
-        worktree.stage(["test.txt"])
+        with self.assertLogs(level="WARNING"):
+            worktree.stage(["test.txt"])
 
         # Check that original content was preserved
         index = self.repo.open_index()
@@ -579,7 +580,8 @@ def test_fallback_to_individual_commands(self):
         )
 
         test_data = b"hello world\n"
-        result = driver.clean(test_data)
+        with self.assertLogs(level="WARNING"):
+            result = driver.clean(test_data)
 
         # Should fallback to tr command and uppercase
         self.assertEqual(result, b"HELLO WORLD\n")
@@ -1156,7 +1158,8 @@ def test_malformed_process_response_handling(self):
             )
 
             # Should fallback to clean_cmd when process fails
-            result = driver.clean(b"test data")
+            with self.assertLogs(level="WARNING"):
+                result = driver.clean(b"test data")
             self.assertEqual(result, b"test data")
 
         finally:

tests/test_lfs_integration.py

@@ -145,5 +145,6 @@ def test_missing_lfs_object(self) -> None:
         blob.data = pointer.to_bytes()
 
         # Checkout should return the pointer as-is when object is missing
-        checked_out = self.normalizer.checkout_normalize(blob, b"missing.bin")
+        with self.assertLogs("dulwich.lfs", level="WARNING"):
+            checked_out = self.normalizer.checkout_normalize(blob, b"missing.bin")
         self.assertEqual(checked_out.data, blob.data)

tests/test_rebase.py

@@ -22,8 +22,6 @@
 """Tests for dulwich.rebase."""
 
 import importlib.util
-import os
-import tempfile
 
 from dulwich.objects import Blob, Commit, Tree
 from dulwich.rebase import (
@@ -36,7 +34,7 @@
     rebase,
     start_interactive,
 )
-from dulwich.repo import MemoryRepo, Repo
+from dulwich.repo import MemoryRepo
 from dulwich.tests.utils import make_commit
 
 from . import DependencyMissing, TestCase