Fix multi (#797)

* fix(docker): Multi does not launch a second Jenkins controller anymore.

* fix(docker): The single quotes prevent $JENKINS_CONTROLLER from being expanded.

* fix(docker): Improve the fallback mechanism implementation.

* fix(docker): Adding error handling for when both controllers are unreachable.

And making the timeout duration configurable.

* fix(ga): Follows the official documentation for the action

https://github.com/docker/login-action?tab=readme-ov-file#github-container-registry

* fix(docker): Wait for 60s before switching to another server.

* fix(ga): Remove trailing spaces.

Author: gounthar

.github/dependabot.yml

@@ -47,7 +47,7 @@ updates:
     directory: "./dockerfiles/agent-discovery"
     schedule:
       interval: weekly
-    open-pull-requests-limit: 10    
+    open-pull-requests-limit: 10
   - package-ecosystem: docker
     directory: "./dockerfiles/android"
     schedule:

.github/workflows/github-docker-registry-push.yml

@@ -91,8 +91,8 @@ jobs:
         uses: docker/login-action@v3
         with:
           registry: ghcr.io
-          username: ${{ env.GHCR_USERNAME }}
-          password: ${{ env.GHCR_TOKEN }}
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Extract branch name
         # This step extracts the branch name

dockerfiles/agent-discovery/find-name.sh

@@ -79,16 +79,16 @@ while true; do
   sleep 2  # Wait for 5 seconds before the next iteration of the loop.
 done
 
-# Check if jenkins_controller is reachable, otherwise fall back to multi_jenkins_controller
+## Check if jenkins_controller is reachable, otherwise fall back to multi_jenkins_controller
 JENKINS_CONTROLLER="jenkins_controller"
-if ! curl -s -f "http://${JENKINS_CONTROLLER}:8080/login" > /dev/null; then
+if ! curl -s -f --max-time 60 "http://${JENKINS_CONTROLLER}:8080/login" > /dev/null; then
     echo "Primary controller not reachable, falling back to multi controller..."
-     JENKINS_CONTROLLER="multi_jenkins_controller"
-     if ! curl -s -f "http://${JENKINS_CONTROLLER}:8080/login" > /dev/null; then
-      echo "Error: Neither primary nor multi controller is reachable"
-      exit 1
+    JENKINS_CONTROLLER="multi_jenkins_controller"
+    if ! curl -s -f --max-time 60 "http://${JENKINS_CONTROLLER}:8080/login" > /dev/null; then
+        echo "Error: Neither primary nor multi controller is reachable"
+        exit 1
     fi
- fi
+fi
 
 # Check If Jenkins is running or not
 # If the message is found, awk exits with a non-zero status (1), and the loop continues.