Skip to content

Commit 56e49d5

Browse files
committed
fix: correct UpdateCLI regex patterns for file matching
Fixed three pattern matching issues: 1. yq pattern: Added missing closing brace '}' before final quote 2. Docker pattern: Simplified to match line-by-line with search filter 3. GitHub CLI pattern: Simplified to match line-by-line with search filter Tested locally - all targets now detect updates correctly: - ⚠ [yq-setup-script] v4.44.3 → v4.48.1 - ⚠ [docker-feature-version] 27.0 → 28.5 - ⚠ [github-cli-feature-version] 2.62 → 2.81.0
1 parent 04fbd74 commit 56e49d5

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

updatecli/updatecli.d/codespaces.yaml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ targets:
7171
scmid: default
7272
spec:
7373
file: .devcontainer/setup.sh
74-
matchpattern: '(YQ_VERSION="\$\{YQ_VERSION:-v)([^"]+)(".*)'
74+
matchpattern: '(YQ_VERSION="\$\{YQ_VERSION:-v)([0-9.]+)(}")'
7575
replacepattern: '${1}{{ source "yq" }}${3}'
7676

7777
docker-feature-version:
@@ -81,8 +81,10 @@ targets:
8181
scmid: default
8282
spec:
8383
file: .devcontainer/devcontainer.json
84-
matchpattern: '("ghcr\.io/devcontainers/features/docker-in-docker:2":\s*\{\s*"version":\s*")([^"]+)(".*)'
84+
matchpattern: '("version": ")([0-9.]+)(",)'
8585
replacepattern: '${1}{{ source "docker-version" }}${3}'
86+
search:
87+
pattern: 'ghcr\.io/devcontainers/features/docker-in-docker'
8688

8789
github-cli-feature-version:
8890
name: '[.devcontainer/devcontainer.json] Bump GitHub CLI version'
@@ -91,8 +93,10 @@ targets:
9193
scmid: default
9294
spec:
9395
file: .devcontainer/devcontainer.json
94-
matchpattern: '("ghcr\.io/devcontainers/features/github-cli:1":\s*\{\s*"version":\s*")([^"]+)(".*)'
96+
matchpattern: '("version": ")([0-9.]+)(")'
9597
replacepattern: '${1}{{ source "github-cli" }}${3}'
98+
search:
99+
pattern: 'ghcr\.io/devcontainers/features/github-cli'
96100

97101
actions:
98102
default:

0 commit comments

Comments
 (0)