Skip to content

Commit 915cb44

Browse files
Update jio-navbar.ts
1 parent 8d3817e commit 915cb44

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

src/jio-navbar.ts

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,7 @@ export class Navbar extends LitElement {
4646
@property()
4747
theme = 'light';
4848

49-
/**
50-
* Supported documentation versions with labels
51-
* @example [{version: '2.504.x', label: 'Stable'}, {version: 'latest', label: 'Nightly'}]
52-
*/
49+
5350
@property({type: Array})
5451
docVersions: Array<{version: string, label: string}> = [
5552
{version: '2.504.x', label: 'Stable'}
@@ -63,13 +60,17 @@ export class Navbar extends LitElement {
6360

6461
/**
6562
* Keeps track of what menu is opened.
63+
*
64+
* Never to be set externally, though storybook shows it.
6665
* @private
6766
*/
6867
@state()
6968
private visibleMenu = -1;
7069

7170
/**
7271
* Keeps track if the collapsed (mobile) menu is shown or not
72+
*
73+
* Never to be set externally, though storybook shows it.
7374
* @private
7475
*/
7576
@state()
@@ -86,7 +87,6 @@ export class Navbar extends LitElement {
8687
super.connectedCallback();
8788
document.addEventListener('click', this.handleDocumentClick);
8889

89-
// Initialize current version from first available if not set
9090
if (!this.currentDocVersion && this.docVersions.length > 0) {
9191
this.currentDocVersion = this.docVersions[0].version;
9292
}
@@ -198,7 +198,6 @@ export class Navbar extends LitElement {
198198
{label: msg("Tekton"), link: "https://tekton.dev/"},
199199
{label: msg("Spinnaker"), link: "https://www.spinnaker.io/"},
200200
];
201-
202201
const menuItems = [
203202
{label: msg("Blog"), link: "/blog/"},
204203
{label: msg("Success Stories"), link: "https://stories.jenkins.io/"},
@@ -371,6 +370,11 @@ export class Navbar extends LitElement {
371370
const assignedElements = slotElement.assignedElements();
372371
const container = slotElement.parentNode as HTMLElement;
373372
for (const element of assignedElements) {
373+
//if (element.slot === "rightMenuItems") {
374+
// const divider = document.createElement('li');
375+
// divider.className = "divider";
376+
// container.appendChild(divider);
377+
//}
374378
for (const link of element.querySelectorAll('jio-navbar-link')) {
375379
const wrapper = document.createElement('li');
376380
wrapper.className = "nav-item";
@@ -444,4 +448,5 @@ declare global {
444448
interface HTMLElementTagNameMap {
445449
'jio-navbar': Navbar;
446450
}
447-
}
451+
}
452+

0 commit comments

Comments
 (0)