Migrating commons-lang API to JDK API

[alecharp]

What feature do you want to see added?

I came across https://docs.openrewrite.org/recipes/apache/commons/lang and I'm wondering if we could use that in modernizer for the removal of commons-lang. Maybe that was considered (in such case, sorry for this noise).

Upstream changes

No response

Are you interested in contributing this feature?

yes.

[Anvarjon7]

Hi @alecharp
I’d be happy to work on this issue if it’s available.

From my understanding, the goal is to reduce or eliminate commons-lang usage by replacing it with JDK equivalents, and potentially leverage OpenRewrite recipes to help automate this migration.

Could you please confirm if my understanding is correct, or suggest how you’d recommend approaching this?

[jonesbusy]

When looking at recent PR it's not fixed yet

There are case we don't want to migrate to commons-lang3. For example if a plugin is using only 2-3 utility that can be replaced by modern Java.

I suggest to take a look at the codebase, previous PR and try to understand how to add a new receipe and test it

Since those recipes are provided directly by openrewrite it's just matter of creating a declarative recipe and ensure it's working by implementing one test.

[s4chinjha]

Hi @jonesbusy
I’m interested in working on this issue.

I understand that the goal is to integrate OpenRewrite recipes for handling commons-lang usage, while considering cases where it can be replaced with modern Java APIs instead of migrating to commons-lang3.

Could you please guide me on where I should start in the codebase and which previous PRs or examples I should look at for adding a new declarative recipe and test?

I’d like to confirm my approach before starting.

[jonesbusy]

https://github.com/jenkins-infra/plugin-modernizer-tool/pull/1519/changes#diff-016bd90eae9c722c19ae08679e26cb654f3144a1365dc503086c95b364dc4207

This create a declarative recipe reusing OpenRewrite one (org.openrewrite.text.CreateTextFile)

This PR show more less what to add (PR title, PR body, recipes.yml, update on DeclarativeTest, update of validate_metadata.py)

[jonesbusy]

Reopening. Was not fully tested

Looks many recipes are missing

I've ran plugin-modernizer dry-run --debug --plugins docker-workflow --recipe MigrateCommonsLangToJdkApi

But doesn't migrate anything except changing some imports

The plugin is using isBlank

Might be related to openrewrite/rewrite-apache#7

Perhaps a PR upstream would be good?

[jonesbusy]

Also I don't think the declarative recipe should reorganize import

For example on the Kubernetes plugin

-import static org.csanchez.jenkins.plugins.kubernetes.pipeline.Resources.*;
+import static org.csanchez.jenkins.plugins.kubernetes.pipeline.Resources.closeQuietly;
+import static org.csanchez.jenkins.plugins.kubernetes.pipeline.Resources.closeQuietlyCallback;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
diff --git a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/ConfigMapVolumeTest.java b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/ConfigMapVolumeTest.java
index 1c7b1fef..7e24f5ff 100644
--- a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/ConfigMapVolumeTest.java
+++ b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/ConfigMapVolumeTest.java
@@ -15,7 +15,8 @@
 
 package org.csanchez.jenkins.plugins.kubernetes;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
 
 import org.csanchez.jenkins.plugins.kubernetes.volumes.ConfigMapVolume;
 import org.junit.Test;
diff --git a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplateTest.java b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplateTest.java
index a879f5d6..fb977434 100644
--- a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplateTest.java
+++ b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplateTest.java
@@ -15,7 +15,8 @@
 
 package org.csanchez.jenkins.plugins.kubernetes;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertThrows;

[ap44444]

Hi @jonesbusy ! I've been looking into this issue and wanted to share my findings.

On the isBlank migration not working:
After checking the OpenRewrite docs, I confirmed there is no recipe that migrates StringUtils.isBlank() to a JDK equivalent, only IsNotEmptyToJdk exists for isEmpty/isNotEmpty. This appears to be blocked by openrewrite/rewrite-apache#7. I'm happy to look into contributing a fix upstream if that would be helpful.

On the unwanted import reorganization:
I traced the wildcard import expansion (e.g. import static org.junit.Assert.* being split into individual imports) to the org.openrewrite.java.RemoveUnusedImports recipe currently included in MigrateCommonsLangToJdkApi. While removing unused commons-lang imports after migration is intentional, it appears RemoveUnusedImports is also reorganizing unrelated imports as a side effect.

Should RemoveUnusedImports be removed from the recipe entirely, or is there a more scoped alternative that only cleans up imports affected by the migration?

[ashutoshbhatt2609]

Hi, I’d like to work on integrating the OpenRewrite commons-lang removal recipe into plugin-modernizer.

Plan:

• Evaluate existing support (if any)
• Test recipe independently
• Integrate and validate on sample plugins

Would appreciate any guidance on where this fits best in the current pipeline.