[JENKINS-75119] Build report UnknownHostException in console log for Bitbucket Server when the server instance is under a context root (#969)

Fix issue in the bitbucket server client when is built the Apache HttpHost from the serverURL. If the Bitbucket Server is installed under a context root different than root ("/"), than the HttpHost built parsing the entire given serverURL throw an UnknownHostException failure in the client. The fix removes the file part of the serverURL.

Author: nfalco79

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/server/client/BitbucketServerAPIClient.java

@@ -954,12 +954,11 @@ protected HttpHost getHost() {
         try {
             // it's really needed?
             URL tmp = new URL(baseURL);
-            if (tmp.getProtocol() == null) {
-                url = new URL("http", tmp.getHost(), tmp.getPort(), tmp.getFile()).toString();
-            }
+            String schema = tmp.getProtocol() == null ? "http" : tmp.getProtocol();
+            return new HttpHost(tmp.getHost(), tmp.getPort(), schema);
         } catch (MalformedURLException e) {
+            return HttpHost.create(url);
         }
-        return HttpHost.create(url);
     }
 
     @Override

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/server/client/BitbucketServerAPIClientTest.java

@@ -13,11 +13,13 @@
 import java.nio.charset.StandardCharsets;
 import java.util.List;
 import org.apache.commons.io.IOUtils;
+import org.apache.http.HttpHost;
 import org.apache.http.HttpRequest;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.client.methods.HttpHead;
 import org.apache.http.client.methods.HttpPost;
 import org.apache.http.client.methods.HttpRequestBase;
+import org.apache.http.client.protocol.HttpClientContext;
 import org.apache.http.impl.client.HttpClientBuilder;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
@@ -34,6 +36,7 @@
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.not;
 import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.RETURNS_SELF;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.mockStatic;
@@ -184,4 +187,17 @@ void verify_getTag_request_URL() throws Exception {
                     .hasPath("/rest/api/1.0/projects/amuniz/repos/test-repos/tags"));
     }
 
+    @Issue("JENKINS-75119")
+    @Test
+    void verify_HttpHost_built_when_server_has_context_root() throws Exception {
+        String serverURL = "https://acme.bitbucket.org/bitbucket";
+        BitbucketServerAPIClient client = (BitbucketServerAPIClient) BitbucketIntegrationClientFactory.getClient(serverURL, "amuniz", "test-repos");
+
+        BitbucketAuthenticator authenticator = extractAuthenticator(client);
+        client.getRepository();
+
+        HttpHost expectedHost = HttpHost.create("https://acme.bitbucket.org");
+        verify(authenticator).configureContext(any(HttpClientContext.class), eq(expectedHost));
+    }
+
 }