Make CasC custom DataBoundConfigurator implementation optional to avoid throw exception when Jenkins startup and CasC plugin not installed (#1108)

Author: nfalco79

README.md

@@ -85,4 +85,4 @@ Support to run Server under Windows has been dismissed since version 7.14+
 3. Inside the container:
    - install git with `apk add git`
    - install git support for http with `apk add git-daemon`
-   - run `/opt/atlassian-plugin-sdk/bin/atlas-run-standalone --product bitbucket --version 9.5.2 "-Dfeature.public.access=true"`
+   - run `/opt/atlassian-plugin-sdk/bin/atlas-run-standalone --product bitbucket --version 9.6.5 --data-version 9.6.5 "-Dfeature.public.access=true"`

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/hooks/BitbucketSCMSourcePushHookReceiver.java

@@ -123,7 +123,7 @@ public HttpResponse doNotify(StaplerRequest2 req) throws IOException {
     }
 
     private BitbucketWebhookProcessor getHookProcessor(Map<String, String> reqHeaders,
-                                                    MultiValuedMap<String, String> reqParameters) {
+                                                       MultiValuedMap<String, String> reqParameters) {
         BitbucketWebhookProcessor hookProcessor;
 
         List<BitbucketWebhookProcessor> matchingProcessors = getHookProcessors()
@@ -146,7 +146,12 @@ private BitbucketWebhookProcessor getHookProcessor(Map<String, String> reqHeader
     }
 
     /*test*/ Stream<BitbucketWebhookProcessor> getHookProcessors() {
-        return ExtensionList.lookup(BitbucketWebhookProcessor.class).stream();
+        ExtensionList<BitbucketWebhookProcessor> processors = ExtensionList.lookup(BitbucketWebhookProcessor.class);
+        if (processors.isEmpty()) {
+            logger.warning(() -> "No registered processors found in the system.");
+            throw new BitbucketWebhookProcessorException(HttpServletResponse.SC_BAD_REQUEST, "No registered processors found in Jenkins. Refer to the user documentation on how configure the webHook in Bitbucket at https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/master/docs/USER_GUIDE.adoc#webhooks-registering");
+        }
+        return processors.stream();
     }
 
     private MultiValuedMap<String, String> getParameters(StaplerRequest2 req) {

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/impl/casc/BitbucketCloudEndpointConfigurator.java

@@ -27,14 +27,14 @@
 import com.cloudbees.jenkins.plugins.bitbucket.impl.endpoint.BitbucketCloudEndpoint;
 import com.cloudbees.jenkins.plugins.bitbucket.impl.webhook.cloud.CloudWebhookConfiguration;
 import edu.umd.cs.findbugs.annotations.NonNull;
-import hudson.Extension;
 import io.jenkins.plugins.casc.ConfigurationAsCode;
 import io.jenkins.plugins.casc.ConfigurationContext;
 import io.jenkins.plugins.casc.Configurator;
 import io.jenkins.plugins.casc.ConfiguratorException;
 import io.jenkins.plugins.casc.impl.configurators.DataBoundConfigurator;
 import io.jenkins.plugins.casc.model.Mapping;
 import java.util.logging.Logger;
+import org.jenkinsci.plugins.variant.OptionalExtension;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
 
@@ -44,7 +44,7 @@
  *
  * @since 937.0.0
  */
-@Extension
+@OptionalExtension(requirePlugins = "configuration-as-code")
 @Restricted(NoExternalUse.class)
 public class BitbucketCloudEndpointConfigurator extends DataBoundConfigurator<BitbucketCloudEndpoint> {
     private static final Logger logger = Logger.getLogger(BitbucketCloudEndpointConfigurator.class.getName());

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/impl/casc/BitbucketServerEndpointConfigurator.java

@@ -28,14 +28,14 @@
 import com.cloudbees.jenkins.plugins.bitbucket.impl.webhook.plugin.PluginWebhookConfiguration;
 import com.cloudbees.jenkins.plugins.bitbucket.impl.webhook.server.ServerWebhookConfiguration;
 import edu.umd.cs.findbugs.annotations.NonNull;
-import hudson.Extension;
 import io.jenkins.plugins.casc.ConfigurationAsCode;
 import io.jenkins.plugins.casc.ConfigurationContext;
 import io.jenkins.plugins.casc.Configurator;
 import io.jenkins.plugins.casc.ConfiguratorException;
 import io.jenkins.plugins.casc.impl.configurators.DataBoundConfigurator;
 import io.jenkins.plugins.casc.model.Mapping;
 import java.util.logging.Logger;
+import org.jenkinsci.plugins.variant.OptionalExtension;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
 
@@ -45,7 +45,7 @@
  *
  * @since 937.0.0
  */
-@Extension
+@OptionalExtension(requirePlugins = "configuration-as-code")
 @Restricted(NoExternalUse.class)
 public class BitbucketServerEndpointConfigurator extends DataBoundConfigurator<BitbucketServerEndpoint> {
     private static final Logger logger = Logger.getLogger(BitbucketServerEndpointConfigurator.class.getName());