Skip to content

Commit 5cd6d8b

Browse files
committed
fix for local env override
1 parent fb4c5cb commit 5cd6d8b

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/main/java/com/browserstack/automate/ci/jenkins/pipeline/AppUploadStepExecution.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@ protected Void run() throws Exception {
4242
return null;
4343
}
4444

45-
EnvVars overrides = run.getEnvironment(taskListener);
46-
overrides.put(BrowserStackEnvVars.BROWSERSTACK_APP_ID, appId);
47-
HashMap<String, String> overridesMap = new HashMap<>(overrides);
45+
HashMap<String, String> overridesMap = new HashMap<String, String>();
46+
overridesMap.put(BrowserStackEnvVars.BROWSERSTACK_APP_ID, appId);
4847

4948
body = getContext().newBodyInvoker()
5049
.withContext(EnvironmentExpander.merge(getContext().get(EnvironmentExpander.class),

src/main/java/com/browserstack/automate/ci/jenkins/pipeline/BrowserStackPipelineStepExecution.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,15 @@ public boolean start() throws Exception {
8787
new BrowserStackBuildWrapperOperations(credentials, false, taskListener.getLogger(),
8888
localConfig, browserStackLocal);
8989

90-
EnvVars overrides = run.getEnvironment(taskListener);
91-
HashMap<String, String> overridesMap = new HashMap<String, String>(overrides);
90+
HashMap<String, String> overridesMap = new HashMap<String, String>();
9291
buildWrapperOperations.buildEnvVars(overridesMap);
9392

9493
body = getContext()
9594
.newBodyInvoker().withContext(credentials).withContext(EnvironmentExpander
9695
.merge(getContext().get(EnvironmentExpander.class), new ExpanderImpl(overridesMap)))
9796
.withCallback(new Callback(browserStackLocal)).start();
9897

98+
EnvVars overrides = run.getEnvironment(taskListener);
9999
tracker.pluginInitialized(overrides.get(Constants.JENKINS_BUILD_TAG),
100100
(this.localConfig != null), true);
101101
return false;

0 commit comments

Comments
 (0)