Skip to content

Commit a016553

Browse files
author
Harshit Vasu
committed
fix: making localConfig optional by providing @DataBoundSetter function for localConfig
1 parent a142e42 commit a016553

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

src/main/java/com/browserstack/automate/ci/jenkins/BrowserStackBuildWrapper.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import hudson.util.DescribableList;
2020
import org.apache.commons.lang.StringUtils;
2121
import org.kohsuke.stapler.DataBoundConstructor;
22+
import org.kohsuke.stapler.DataBoundSetter;
2223

2324
import java.io.IOException;
2425
import java.io.PrintStream;
@@ -31,15 +32,19 @@ public class BrowserStackBuildWrapper extends BuildWrapper {
3132

3233
private static final char CHAR_MASK = '*';
3334

34-
private final LocalConfig localConfig;
35+
private LocalConfig localConfig;
3536

3637
private String credentialsId;
3738
private String username;
3839
private String accesskey;
3940

4041
@DataBoundConstructor
41-
public BrowserStackBuildWrapper(String credentialsId, LocalConfig localConfig) {
42+
public BrowserStackBuildWrapper(String credentialsId) {
4243
this.credentialsId = credentialsId;
44+
}
45+
46+
@DataBoundSetter
47+
public void setLocalConfig(LocalConfig localConfig) {
4348
this.localConfig = localConfig;
4449
}
4550

src/test/java/com/browserstack/automate/ci/jenkins/AutomateTestActionTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@ public void addBuildStep() throws IOException {
124124
localConfig.setLocalOptions("-force");
125125

126126
BrowserStackBuildWrapper buildWrapper =
127-
new BrowserStackBuildWrapper(credentialsId, localConfig);
127+
new BrowserStackBuildWrapper(credentialsId);
128+
buildWrapper.setLocalConfig(localConfig);
128129
project.getBuildWrappersList().add(buildWrapper);
129130
}
130131

src/test/java/com/browserstack/automate/ci/jenkins/AutomateTestDataPublisherTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,8 @@ public void addBuildStep() throws IOException {
115115
LocalConfig localConfig = new LocalConfig();
116116
localConfig.setLocalOptions("-force");
117117

118-
BrowserStackBuildWrapper buildWrapper = new BrowserStackBuildWrapper(credentialsId, localConfig);
118+
BrowserStackBuildWrapper buildWrapper = new BrowserStackBuildWrapper(credentialsId);
119+
buildWrapper.setLocalConfig(localConfig);
119120
project.getBuildWrappersList().add(buildWrapper);
120121
}
121122

0 commit comments

Comments
 (0)