Skip to content

Commit aca8e7a

Browse files
[JENKINS-74133] Extract inline JavaScript from AutomateTestAction/summary.jelly
1 parent ccbc7de commit aca8e7a

File tree

2 files changed

+18
-17
lines changed

2 files changed

+18
-17
lines changed
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
document.addEventListener("DOMContentLoaded", () => {
2+
const { sessionId } = document.querySelector(".browserstack-analytics-data-holder").dataset;
3+
4+
var startTime = (new Date).valueOf();
5+
function onLoadIFrame() {
6+
testAction.iframeLoadTime((new Date).valueOf() - startTime);
7+
}
8+
9+
var iframeElem = document.getElementById('browserstack-iframe-' + sessionId);
10+
if (iframeElem.addEventListener) {
11+
iframeElem.addEventListener('load', onLoadIFrame, true);
12+
} else if (iframeElem.attachEvent) {
13+
iframeElem.attachEvent('onload', onLoadIFrame);
14+
}
15+
});

src/main/resources/com/browserstack/automate/ci/jenkins/AutomateTestAction/summary.jelly

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -35,23 +35,9 @@
3535

3636
<iframe id="browserstack-iframe-${session.id}" src="${session.publicUrl}" class="browserstack-session-frame" allowfullscreen="true" webkitallowfullscreen="true" mozallowfullscreen="true" />
3737

38-
<script type="text/javascript">
39-
var testAction = <st:bind value="${it}"/>
40-
var sessionId = <st:bind value="${session.id}" />
41-
//<![CDATA[
42-
var startTime = (new Date).valueOf();
43-
function onLoadIFrame() {
44-
testAction.iframeLoadTime((new Date).valueOf() - startTime);
45-
}
46-
47-
var iframeElem = document.getElementById('browserstack-iframe-' + sessionId);
48-
if (iframeElem.addEventListener) {
49-
iframeElem.addEventListener('load', onLoadIFrame, true);
50-
} else if (iframeElem.attachEvent) {
51-
iframeElem.attachEvent('onload', onLoadIFrame);
52-
}
53-
//]]>
54-
</script>
38+
<st:bind value="${it}" var="testAction"/>
39+
<span class="browserstack-analytics-data-holder" data-session-id="${session.id}"/>
40+
<st:adjunct includes="com.browserstack.automate.ci.jenkins.AutomateTestAction.resource"/>
5541

5642
<style type="text/css">
5743
.browserstack-session-frame {

0 commit comments

Comments
 (0)