Skip to content

Commit 1940b1e

Browse files
committed
Add JenkinsFacade to details column (stubbing of symbol registry).
1 parent ccd8d0b commit 1940b1e

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

src/main/java/io/jenkins/plugins/datatables/TableColumn.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,7 @@ public class TableColumn {
3838
* @return the HTML div to create the details column
3939
*/
4040
public static String renderDetailsColumn(final String detailsText) {
41-
return div()
42-
.withClass("details-control")
43-
.attr("data-description", detailsText)
44-
.with(join(symbol("add", "open"),
45-
symbol("remove", "close"))).render();
41+
return renderDetailsColumn(detailsText, new JenkinsFacade());
4642
}
4743

4844
/**
@@ -51,17 +47,20 @@ public static String renderDetailsColumn(final String detailsText) {
5147
* @param detailsText
5248
* the text to show if the column has been expanded.
5349
* @param jenkinsFacade
54-
* facade for Jenkins API calls
50+
* facade for Jenkins API calls to get symbols
5551
*
5652
* @return the HTML div to create the details column
57-
* @deprecated use {@link #renderDetailsColumn(String)}
5853
*/
59-
@Deprecated
60-
public static String renderDetailsColumn(final String detailsText, @SuppressWarnings("unused") final JenkinsFacade jenkinsFacade) {
61-
return renderDetailsColumn(detailsText);
54+
public static String renderDetailsColumn(final String detailsText,
55+
@SuppressWarnings("unused") final JenkinsFacade jenkinsFacade) {
56+
return div()
57+
.withClass("details-control")
58+
.attr("data-description", detailsText)
59+
.with(join(symbol("add", "open", jenkinsFacade),
60+
symbol("remove", "close", jenkinsFacade))).render();
6261
}
6362

64-
private static String symbol(final String imageName, final String cssId) {
63+
private static String symbol(final String imageName, final String cssId, final JenkinsFacade jenkins) {
6564
return Symbol.get(new Builder()
6665
.withName(imageName + "-circle-outline")
6766
.withPluginName("ionicons-api")
@@ -354,7 +353,8 @@ public enum ColumnType {
354353
/** Numbers will be shown right aligned, and use a simple number sorting. */
355354
NUMBER("num"),
356355
/**
357-
* Numbers will be shown right aligned, and use a simple number sorting. May contain HTML tags also in the data.
356+
* Numbers will be shown right aligned, and use a simple number sorting. May contain HTML tags also in the
357+
* data.
358358
*/
359359
HTML_NUMBER("html-num"),
360360
/**

0 commit comments

Comments
 (0)