Merge pull request #346 from jenkinsci/symbol-stub

Add `JenkinsFacade` to details column (stubbing of symbol registry)

Author: uhafner

pom.xml

@@ -260,6 +260,13 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.revapi</groupId>
+        <artifactId>revapi-maven-plugin</artifactId>
+        <configuration>
+          <skip>true</skip>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 

src/main/java/io/jenkins/plugins/datatables/TableColumn.java

@@ -1,7 +1,6 @@
 package io.jenkins.plugins.datatables;
 
 import org.apache.commons.lang3.StringUtils;
-import org.jenkins.ui.symbol.Symbol;
 import org.jenkins.ui.symbol.SymbolRequest.Builder;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
@@ -38,11 +37,7 @@ public class TableColumn {
      * @return the HTML div to create the details column
      */
     public static String renderDetailsColumn(final String detailsText) {
-        return div()
-                .withClass("details-control")
-                .attr("data-description", detailsText)
-                .with(join(symbol("add", "open"),
-                        symbol("remove", "close"))).render();
+        return renderDetailsColumn(detailsText, new JenkinsFacade());
     }
 
     /**
@@ -51,18 +46,20 @@ public static String renderDetailsColumn(final String detailsText) {
      * @param detailsText
      *         the text to show if the column has been expanded.
      * @param jenkinsFacade
-     *         facade for Jenkins API calls
+     *         facade for Jenkins API calls to get symbols
      *
      * @return the HTML div to create the details column
-     * @deprecated use {@link #renderDetailsColumn(String)}
      */
-    @Deprecated
-    public static String renderDetailsColumn(final String detailsText, @SuppressWarnings("unused") final JenkinsFacade jenkinsFacade) {
-        return renderDetailsColumn(detailsText);
+    public static String renderDetailsColumn(final String detailsText, final JenkinsFacade jenkinsFacade) {
+        return div()
+                .withClass("details-control")
+                .attr("data-description", detailsText)
+                .with(join(symbol("add", "open", jenkinsFacade),
+                        symbol("remove", "close", jenkinsFacade))).render();
     }
 
-    private static String symbol(final String imageName, final String cssId) {
-        return Symbol.get(new Builder()
+    private static String symbol(final String imageName, final String cssId, final JenkinsFacade jenkins) {
+        return jenkins.getSymbol(new Builder()
                 .withName(imageName + "-circle-outline")
                 .withPluginName("ionicons-api")
                 .withClasses("details-icon details-icon-" + cssId)
@@ -354,7 +351,8 @@ public enum ColumnType {
         /** Numbers will be shown right aligned, and use a simple number sorting. */
         NUMBER("num"),
         /**
-         * Numbers will be shown right aligned, and use a simple number sorting. May contain HTML tags also in the data.
+         * Numbers will be shown right aligned, and use a simple number sorting. May contain HTML tags also in the
+         * data.
          */
         HTML_NUMBER("html-num"),
         /**