chore(linux): install git-lfs from repository instead of Linux distribution packages
#1009
Conversation
…ribution packages
| && ln -sf /usr/share/jenkins/agent.jar /usr/share/jenkins/slave.jar | ||
|
|
||
| ARG GIT_LFS_VERSION=3.7.0 | ||
| RUN arch=$(uname -m | sed -e 's/x86_64/amd64/g' -e 's/aarch64/arm64/g' -e 's/armv7l/arm/g') \ |
There was a problem hiding this comment.
Added this third sed replacement pattern to Debian images which include Linux/arm/v7 architecture
There was a problem hiding this comment.
Nit question: wouldn't it work with dpkg --print-architecture? (For arm64 it works, but I'm not sure for arm/v7)
There was a problem hiding this comment.
I haven't tested. What would be the benefit of using dpkg instead of uname in that case?
There was a problem hiding this comment.
dpkg --print-architecture (I'm not 100% sure of the flag, worth checking the doc.) is usually called when you expect a "Golang/Docker" CPU architecture string such as amd64 or arm64 instead of the Kernel designations from uname.
It avoids doing tedious text search and replace techniques (whatever techniques: shell search/replace, sed, awk, perl, etc.).
There was a problem hiding this comment.
@dduportal after testing, as dpkg is not available in Alpine nor in UBI9 images, and as dpkg --print-architecture returns armhf for Linux/arm/v7 and thus still requires a sed into arm in that case, I propose to keep uname -m in all images for uniformity.
WDYT?
There was a problem hiding this comment.
With the test checking we can, at least, instantiate the binary (Golang binary), the Alpine and Ubi implementations should be good (even if we have to be aware that we might break them since the static binary could rely on other libraries or packages) . But LGTM!
3 participants
This PR installs
git-lfsfrom its repository instead of relying on Linux distribution packages, to ensure we're getting the same version installed accross all images.Ref:
git-lfs#1008I'll open another PR for updatecli manifest.
Testing done
make build testSubmitter checklist