breaking: stop providing Windows 1809 images (#1152)

Author: lemeurherve

Jenkinsfile

@@ -9,8 +9,8 @@ properties([
 def agentSelector(String imageType, retryCounter) {
     def platform
     switch (imageType) {
-        // nanoserver-1809, nanoserver-ltsc2019 and windowservercore-ltsc2019
-        case ~/.*(1809|2019)/:
+        // nanoserver-ltsc2019 and windowservercore-ltsc2019
+        case ~/.*2019/:
             platform = 'windows-2019'
             break
 
@@ -43,10 +43,8 @@ def agentSelector(String imageType, retryCounter) {
 def parallelStages = [failFast: false]
 [
     'linux',
-    'nanoserver-1809',
     'nanoserver-ltsc2019',
     'nanoserver-ltsc2022',
-    'windowsservercore-1809',
     'windowsservercore-ltsc2019',
     'windowsservercore-ltsc2022'
 ].each { imageType ->

README.md

@@ -387,12 +387,10 @@ Add the `-DryRun` parameter to print out any build, publish or tests commands in
 
 #### Building and testing a specific image
 
-You can build (and test) only one image type by setting `-ImageType` to a combination of Windows flavors ("nanoserver" & "windowsservercore") and Windows versions ("1809", "ltsc2019", "ltsc2022").
+You can build (and test) only one image type by setting `-ImageType` to a combination of Windows flavors ("nanoserver" & "windowsservercore") and Windows versions ("ltsc2019", "ltsc2022").
 
 Ex: `.\build.ps1 -ImageType 'nanoserver-ltsc2019'`
 
-Warning: trying to build `windowsservercore-1809` will fail as there is no corresponding image from Microsoft.
-
 You can also build (and test) only one agent type by setting `-AgentType` to either "agent" or "inbound-agent".
 
 Ex: `.\build.ps1 -AgentType 'agent'`

README_agent.md

@@ -48,56 +48,7 @@ docker run -i --rm --name agent1 --init -v agent1-workdir:C:/Users/jenkins/Work
 
 ## Configurations
 
-The image has several supported configurations, which can be accessed via the following tags:
-
-* Linux Images:
-  * Java 17 (default):
-    * `jenkins/agent:latest`: Based on `debian:trixie-${builddate}`
-      * Also tagged as: 
-        * `jenkins/agent:jdk17`
-        * `jenkins/agent:trixie-jdk17`
-        * `jenkins/agent:latest-trixie`
-        * `jenkins/agent:latest-trixie-jdk17`
-        * `jenkins/agent:latest-jdk17`
-    * alpine (Small image based on Alpine Linux, based on `alpine:${version}`):
-      * `jenkins/agent:alpine` 
-      * `jenkins/agent:alpine-jdk17`
-      * `jenkins/agent:latest-alpine`
-      * `jenkins/agent:latest-alpine-jdk17`
-    * rhel-ubi9 (Based on Red Hat Universal Base Image 9)
-      * `jenkins/agent:rhel-ubi9`
-      * `jenkins/agent:rhel-ubi9-jdk17`
-      * `jenkins/agent:latest-rhel-ubi9`
-      * `jenkins/agent:latest-rhel-ubi9-jdk17`
-  * Java 21:
-    * trixie (Based on `debian:trixie-${builddate}`):
-      * `jenkins/agent:trixie`
-      * `jenkins/agent:trixie-jdk21`
-      * `jenkins/agent:jdk21`
-      * `jenkins/agent:latest-trixie-jdk21`
-    * alpine (Small image based on Alpine Linux, based on `alpine:${version}`):
-      * `jenkins/agent:alpine-jdk21`
-      * `jenkins/agent:latest-alpine`
-      * `jenkins/agent:latest-alpine-jdk21`
-    * rhel-ubi9 (Based on Red Hat Universal Base Image 9)
-      * `jenkins/agent:rhel-ubi9-jdk21`
-      * `jenkins/agent:latest-rhel-ubi9-jdk21`
-
-* Windows Images:
-  * Java 17 (default):
-    * Latest Jenkins agent version on Windows Nano Server and Java 17:
-      * `jenkins/agent:jdk17-nanoserver-1809`
-      * `jenkins/agent:jdk17-nanoserver-ltsc2019`
-      * `jenkins/agent:jdk17-nanoserver-ltsc2022`
-  * Java 21:
-    * Latest Jenkins agent version on Windows Nano Server and Java 21:
-      * `jenkins/agent:jdk21-nanoserver-1809`
-      * `jenkins/agent:jdk21-nanoserver-ltsc2019`
-      * `jenkins/agent:jdk21-nanoserver-ltsc2022`
-    * Latest Jenkins agent version on Windows Server Core with Java 21:
-      * `jenkins/agent:jdk21-windowsservercore-1809`
-      * `jenkins/agent:jdk21-windowsservercore-ltsc2019`
-      * `jenkins/agent:jdk21-windowsservercore-ltsc2022`
+The image has several supported configurations, which can be accessed via the lists of tags that can be consulted at https://github.com/jenkinsci/docker-agents/tree/master/tests/golden/
 
 The file [docker-bake.hcl](https://github.com/jenkinsci/docker-agents/blob/master/docker-bake.hcl) defines all the configuration for Linux images and their associated tags.
 

docker-bake.hcl

@@ -266,16 +266,13 @@ function "debian_platforms" {
 }
 
 # Return array of Windows version(s) to build
-# There is no mcr.microsoft.com/windows/servercore:1809 image
 # Can be overriden by setting WINDOWS_VERSION_OVERRIDE to a specific Windows version
-# Ex: WINDOWS_VERSION_OVERRIDE=1809 docker buildx bake windows
+# Ex: WINDOWS_VERSION_OVERRIDE=ltsc2025 docker buildx bake windows
 function "windowsversions" {
   params = [flavor]
   result = (notequal(WINDOWS_VERSION_OVERRIDE, "")
     ? [WINDOWS_VERSION_OVERRIDE]
-    : (equal(flavor, "windowsservercore")
-      ? ["ltsc2019", "ltsc2022"]
-  : ["1809", "ltsc2019", "ltsc2022"]))
+    : ["ltsc2019", "ltsc2022"])
 }
 
 # Return array of agent type(s) to build

tests/agent.Tests.ps1

@@ -1,6 +1,6 @@
 Import-Module -DisableNameChecking -Force $PSScriptRoot/test_helpers.psm1
 
-$global:IMAGE_NAME = Get-EnvOrDefault 'IMAGE_NAME' '' # Ex: jenkins/agent:jdk17-nanoserver-1809
+$global:IMAGE_NAME = Get-EnvOrDefault 'IMAGE_NAME' '' # Ex: jenkins/agent:ltsc2022
 $global:VERSION = Get-EnvOrDefault 'VERSION' ''
 $global:JAVA_VERSION = Get-EnvOrDefault 'JAVA_VERSION' ''
 

tests/golden/expected_tags_windows.txt

@@ -1,29 +1,23 @@
-docker.io/jenkins/agent:jdk17-nanoserver-1809
 docker.io/jenkins/agent:jdk17-nanoserver-ltsc2019
 docker.io/jenkins/agent:jdk17-nanoserver-ltsc2022
 docker.io/jenkins/agent:jdk17-windowsservercore-ltsc2019
 docker.io/jenkins/agent:jdk17-windowsservercore-ltsc2022
-docker.io/jenkins/agent:jdk21-nanoserver-1809
 docker.io/jenkins/agent:jdk21-nanoserver-ltsc2019
 docker.io/jenkins/agent:jdk21-nanoserver-ltsc2022
 docker.io/jenkins/agent:jdk21-windowsservercore-ltsc2019
 docker.io/jenkins/agent:jdk21-windowsservercore-ltsc2022
-docker.io/jenkins/agent:jdk25-nanoserver-1809
 docker.io/jenkins/agent:jdk25-nanoserver-ltsc2019
 docker.io/jenkins/agent:jdk25-nanoserver-ltsc2022
 docker.io/jenkins/agent:jdk25-windowsservercore-ltsc2019
 docker.io/jenkins/agent:jdk25-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:jdk17-nanoserver-1809
 docker.io/jenkins/inbound-agent:jdk17-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:jdk17-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:jdk17-windowsservercore-ltsc2019
 docker.io/jenkins/inbound-agent:jdk17-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:jdk21-nanoserver-1809
 docker.io/jenkins/inbound-agent:jdk21-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:jdk21-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:jdk21-windowsservercore-ltsc2019
 docker.io/jenkins/inbound-agent:jdk21-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:jdk25-nanoserver-1809
 docker.io/jenkins/inbound-agent:jdk25-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:jdk25-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:jdk25-windowsservercore-ltsc2019

tests/golden/expected_tags_windows_on_tag.txt

@@ -1,79 +1,63 @@
-docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk17-nanoserver-1809
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk17-nanoserver-ltsc2019
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk17-nanoserver-ltsc2022
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk17-windowsservercore-ltsc2019
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk17-windowsservercore-ltsc2022
-docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk21-nanoserver-1809
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk21-nanoserver-ltsc2019
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk21-nanoserver-ltsc2022
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk21-windowsservercore-ltsc2019
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk21-windowsservercore-ltsc2022
-docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk25-nanoserver-1809
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk25-nanoserver-ltsc2019
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk25-nanoserver-ltsc2022
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk25-windowsservercore-ltsc2019
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-jdk25-windowsservercore-ltsc2022
-docker.io/jenkins/agent:3355.v388858a_47b_33-1-nanoserver-1809
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-nanoserver-ltsc2019
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-nanoserver-ltsc2022
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-windowsservercore-ltsc2019
 docker.io/jenkins/agent:3355.v388858a_47b_33-1-windowsservercore-ltsc2022
-docker.io/jenkins/agent:jdk17-nanoserver-1809
 docker.io/jenkins/agent:jdk17-nanoserver-ltsc2019
 docker.io/jenkins/agent:jdk17-nanoserver-ltsc2022
 docker.io/jenkins/agent:jdk17-windowsservercore-ltsc2019
 docker.io/jenkins/agent:jdk17-windowsservercore-ltsc2022
-docker.io/jenkins/agent:jdk21-nanoserver-1809
 docker.io/jenkins/agent:jdk21-nanoserver-ltsc2019
 docker.io/jenkins/agent:jdk21-nanoserver-ltsc2022
 docker.io/jenkins/agent:jdk21-windowsservercore-ltsc2019
 docker.io/jenkins/agent:jdk21-windowsservercore-ltsc2022
-docker.io/jenkins/agent:jdk25-nanoserver-1809
 docker.io/jenkins/agent:jdk25-nanoserver-ltsc2019
 docker.io/jenkins/agent:jdk25-nanoserver-ltsc2022
 docker.io/jenkins/agent:jdk25-windowsservercore-ltsc2019
 docker.io/jenkins/agent:jdk25-windowsservercore-ltsc2022
-docker.io/jenkins/agent:nanoserver-1809
 docker.io/jenkins/agent:nanoserver-ltsc2019
 docker.io/jenkins/agent:nanoserver-ltsc2022
 docker.io/jenkins/agent:windowsservercore-ltsc2019
 docker.io/jenkins/agent:windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk17-nanoserver-1809
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk17-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk17-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk17-windowsservercore-ltsc2019
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk17-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk21-nanoserver-1809
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk21-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk21-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk21-windowsservercore-ltsc2019
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk21-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk25-nanoserver-1809
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk25-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk25-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk25-windowsservercore-ltsc2019
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-jdk25-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-nanoserver-1809
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-windowsservercore-ltsc2019
 docker.io/jenkins/inbound-agent:3355.v388858a_47b_33-1-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:jdk17-nanoserver-1809
 docker.io/jenkins/inbound-agent:jdk17-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:jdk17-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:jdk17-windowsservercore-ltsc2019
 docker.io/jenkins/inbound-agent:jdk17-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:jdk21-nanoserver-1809
 docker.io/jenkins/inbound-agent:jdk21-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:jdk21-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:jdk21-windowsservercore-ltsc2019
 docker.io/jenkins/inbound-agent:jdk21-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:jdk25-nanoserver-1809
 docker.io/jenkins/inbound-agent:jdk25-nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:jdk25-nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:jdk25-windowsservercore-ltsc2019
 docker.io/jenkins/inbound-agent:jdk25-windowsservercore-ltsc2022
-docker.io/jenkins/inbound-agent:nanoserver-1809
 docker.io/jenkins/inbound-agent:nanoserver-ltsc2019
 docker.io/jenkins/inbound-agent:nanoserver-ltsc2022
 docker.io/jenkins/inbound-agent:windowsservercore-ltsc2019

tests/inbound-agent.Tests.ps1

@@ -1,6 +1,6 @@
 Import-Module -DisableNameChecking -Force $PSScriptRoot/test_helpers.psm1
 
-$global:IMAGE_NAME = Get-EnvOrDefault 'IMAGE_NAME' '' # Ex: jenkins/inbound-agent:jdk17-nanoserver-1809
+$global:IMAGE_NAME = Get-EnvOrDefault 'IMAGE_NAME' '' # Ex: jenkins/inbound-agent:ltsc2022
 $global:VERSION = Get-EnvOrDefault 'VERSION' ''
 $global:JAVA_VERSION = Get-EnvOrDefault 'JAVA_VERSION' ''
 

tests/netcat-helper/Dockerfile-windows

@@ -23,7 +23,7 @@
 #  THE SOFTWARE.
 
 # Available tags: https://mcr.microsoft.com/v2/windows/servercore/tags/list
-ARG WINDOWS_VERSION_TAG=1809
+ARG WINDOWS_VERSION_TAG=ltsc2022
 FROM mcr.microsoft.com/windows/servercore:"${WINDOWS_VERSION_TAG}"
 
 SHELL ["powershell.exe", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]