diff --git a/src/main/java/jenkins/plugins/extracolumns/CronTriggerColumn.java b/src/main/java/jenkins/plugins/extracolumns/CronTriggerColumn.java index d86ce53..4bf758a 100644 --- a/src/main/java/jenkins/plugins/extracolumns/CronTriggerColumn.java +++ b/src/main/java/jenkins/plugins/extracolumns/CronTriggerColumn.java @@ -61,10 +61,8 @@ public String getCronTrigger(@SuppressWarnings("rawtypes") Job job) { } Map> triggers = null; - if (job instanceof AbstractProject) { - triggers = ((AbstractProject) job).getTriggers(); - } if (job instanceof ParameterizedJobMixIn.ParameterizedJob) { - triggers = ((ParameterizedJobMixIn.ParameterizedJob)job).getTriggers(); + if (job instanceof ParameterizedJobMixIn.ParameterizedJob pj) { + triggers = pj.getTriggers(); } if (triggers == null) { diff --git a/src/main/java/jenkins/plugins/extracolumns/DescriptionColumn.java b/src/main/java/jenkins/plugins/extracolumns/DescriptionColumn.java index ce4ed7a..1f58aa6 100644 --- a/src/main/java/jenkins/plugins/extracolumns/DescriptionColumn.java +++ b/src/main/java/jenkins/plugins/extracolumns/DescriptionColumn.java @@ -93,7 +93,7 @@ private String formatDescription(AbstractItem job, boolean trimIt) { return ""; } - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); if (!trimIt) { sb.append(job.getDescription()); } else { diff --git a/src/main/java/jenkins/plugins/extracolumns/LastBuildNodeColumn.java b/src/main/java/jenkins/plugins/extracolumns/LastBuildNodeColumn.java index 933c572..9e386fa 100644 --- a/src/main/java/jenkins/plugins/extracolumns/LastBuildNodeColumn.java +++ b/src/main/java/jenkins/plugins/extracolumns/LastBuildNodeColumn.java @@ -44,8 +44,8 @@ public LastBuildNodeColumn() { public String getLastBuildNode(Job job) { Run lastBuild = job.getLastBuild(); - if (lastBuild instanceof AbstractBuild) { - Node builtOn = ((AbstractBuild) lastBuild).getBuiltOn(); + if (lastBuild instanceof AbstractBuild ab) { + Node builtOn = ab.getBuiltOn(); if (builtOn instanceof Jenkins) { return "master"; } @@ -56,6 +56,17 @@ public String getLastBuildNode(Job job) { return null; } + public String getLastBuildNodeDescription(Job job) { + Run lastBuild = job.getLastBuild(); + if (lastBuild instanceof AbstractBuild ab) { + Node builtOn = ab.getBuiltOn(); + if (builtOn != null) { + return builtOn.getNodeDescription(); + } + } + return null; + } + @Extension public static class DescriptorImpl extends ListViewColumnDescriptor { diff --git a/src/main/java/jenkins/plugins/extracolumns/SCMTypeColumn.java b/src/main/java/jenkins/plugins/extracolumns/SCMTypeColumn.java index c68b4be..1a9a6d4 100644 --- a/src/main/java/jenkins/plugins/extracolumns/SCMTypeColumn.java +++ b/src/main/java/jenkins/plugins/extracolumns/SCMTypeColumn.java @@ -45,22 +45,21 @@ public SCMTypeColumn() { } public String getScmType(@SuppressWarnings("rawtypes") Job job) { - if(job instanceof AbstractProject) { - AbstractProject project = (AbstractProject) job; + if(job instanceof AbstractProject project) { return project.getScm().getDescriptor().getDisplayName(); } else { String simpleName = job.getClass().getSimpleName(); if ("WorkflowJob".equals(simpleName)) { - Jenkins instance = Jenkins.getInstance(); - if (instance != null && instance.getPlugin("workflow-job") != null) { + Jenkins instance = Jenkins.get(); + if (instance.getPlugin("workflow-job") != null) { org.jenkinsci.plugins.workflow.job.WorkflowJob wfj = (org.jenkinsci.plugins.workflow.job.WorkflowJob) job; Collection scms = wfj.getSCMs(); - if (scms.size() == 0) { + if (scms.isEmpty()) { return "N/A"; } - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (SCM scm : scms) { - sb.append(scm.getDescriptor().getDisplayName() + "\n"); + sb.append(scm.getDescriptor().getDisplayName()).append("\n"); } return sb.toString(); } diff --git a/src/main/java/jenkins/plugins/extracolumns/SlaveOrLabelColumn.java b/src/main/java/jenkins/plugins/extracolumns/SlaveOrLabelColumn.java index 210d6fb..404349c 100644 --- a/src/main/java/jenkins/plugins/extracolumns/SlaveOrLabelColumn.java +++ b/src/main/java/jenkins/plugins/extracolumns/SlaveOrLabelColumn.java @@ -48,13 +48,12 @@ public SlaveOrLabelColumn() { } public Label getLabel(Job job) { - if(!(job instanceof AbstractProject)){ + if(!(job instanceof AbstractProject ap)){ LOGGER.finest("Not an instance of " + AbstractProject.class.getCanonicalName() + ". Cannot get info."); return null; } - AbstractProject project = AbstractProject.class.cast(job); - return project.getAssignedLabel(); + return ap.getAssignedLabel(); } public String getDescription(Label label) { @@ -62,7 +61,7 @@ public String getDescription(Label label) { return ""; } String desc = label.getDescription(); - return (desc == null || desc.length() < 1) ? "" : "(" + desc + ")"; + return (desc == null || desc.isEmpty()) ? "" : "(" + desc + ")"; } @Extension diff --git a/src/main/resources/jenkins/plugins/extracolumns/BuildDescriptionColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/BuildDescriptionColumn/config.jelly index 2788670..82ce2e9 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/BuildDescriptionColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/BuildDescriptionColumn/config.jelly @@ -26,16 +26,11 @@ - - - - - - - - - - -
${%This column shows the build description of the last build.}
-
-
\ No newline at end of file + + + + + + + + diff --git a/src/main/resources/jenkins/plugins/extracolumns/BuildDurationColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/BuildDurationColumn/column.jelly index d0c6c61..8962e30 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/BuildDurationColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/BuildDurationColumn/column.jelly @@ -56,5 +56,5 @@ THE SOFTWARE. - ${buildDurationString} + ${buildDurationString} diff --git a/src/main/resources/jenkins/plugins/extracolumns/BuildDurationColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/BuildDurationColumn/config.jelly index feb7ef7..c6d66f2 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/BuildDurationColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/BuildDurationColumn/config.jelly @@ -24,14 +24,14 @@ THE SOFTWARE. - -

${%This column shows the last build duration.}

+

${%This column shows the last build duration.}

- ${%Time since build started} ${%Average duration} ${%Average duration in minutes-compact} + -
diff --git a/src/main/resources/jenkins/plugins/extracolumns/BuildParametersColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/BuildParametersColumn/config.jelly index 6e6aa9c..e91a6ad 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/BuildParametersColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/BuildParametersColumn/config.jelly @@ -26,12 +26,10 @@ - -

${%This column shows either all build parameters or build parameters matching a regular expression of the current/last build.}

+

${%This column shows either all build parameters or build parameters matching a regular expression of the current/last build.}

-
\ No newline at end of file diff --git a/src/main/resources/jenkins/plugins/extracolumns/ConfigureProjectColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/ConfigureProjectColumn/column.jelly index 9754301..f6e583a 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/ConfigureProjectColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/ConfigureProjectColumn/column.jelly @@ -27,7 +27,7 @@ THE SOFTWARE. - + diff --git a/src/main/resources/jenkins/plugins/extracolumns/ConfigureProjectColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/ConfigureProjectColumn/config.jelly index f206eea..9a32d30 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/ConfigureProjectColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/ConfigureProjectColumn/config.jelly @@ -24,14 +24,6 @@ THE SOFTWARE. - - - - - - -

${%This column adds a shortcut to the configuration page of a project.}

- - -
+ +

${%This column adds a shortcut to the configuration page of a project.}

diff --git a/src/main/resources/jenkins/plugins/extracolumns/CronTriggerColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/CronTriggerColumn/column.jelly index 0b59b4a..4376688 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/CronTriggerColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/CronTriggerColumn/column.jelly @@ -25,8 +25,8 @@ - - ${it.getCronTrigger(job)} + + ${it.getCronTrigger(job)} diff --git a/src/main/resources/jenkins/plugins/extracolumns/CronTriggerColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/CronTriggerColumn/config.jelly index dd4ea67..29c4108 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/CronTriggerColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/CronTriggerColumn/config.jelly @@ -26,11 +26,5 @@ - - - - - -
${%This column shows the periodic build trigger for the job in cron format.}
-
+

${%This column shows the periodic build trigger for the job in cron format.}

\ No newline at end of file diff --git a/src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/column.jelly index 0870c12..4ba1679 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/column.jelly @@ -30,10 +30,10 @@ - ${relativeDisplayName != null ? relativeDisplayName : job.displayName}
+ ${relativeDisplayName != null ? relativeDisplayName : job.displayName}
-
- +
+
diff --git a/src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/config.jelly index e547204..ea47812 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/DescriptionColumn/config.jelly @@ -26,26 +26,18 @@ - - - - - - - - - - - - - - - - - - -
${%This column shows the project description.}
- -
-
+

${%This column shows the project description.}

+ + + + + + + + + + + + +
\ No newline at end of file diff --git a/src/main/resources/jenkins/plugins/extracolumns/DisableProjectColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/DisableProjectColumn/config.jelly index c9c50ad..540597a 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/DisableProjectColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/DisableProjectColumn/config.jelly @@ -24,19 +24,8 @@ THE SOFTWARE. - - - -

${%This column adds a button or an icon for disabling/enabling a project.}

- - - - - - - -
- - -
+ + + +
diff --git a/src/main/resources/jenkins/plugins/extracolumns/JobTypeColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/JobTypeColumn/config.jelly index 0b4af64..31b0cb4 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/JobTypeColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/JobTypeColumn/config.jelly @@ -24,17 +24,7 @@ THE SOFTWARE. - - - - - - -

${%This column shows the type of the job, eg. Free-style, Maven, Multi-config, Pipeline.}

- - - - - -
+ + +
diff --git a/src/main/resources/jenkins/plugins/extracolumns/LastBuildColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/LastBuildColumn/column.jelly index e05ec6e..b84f23e 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/LastBuildColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/LastBuildColumn/column.jelly @@ -48,10 +48,10 @@ THE SOFTWARE. - ${lastBuildString} - ${lastBuild.displayName} + ${lastBuildString} ${lastBuild.displayName} - ${lastBuildString} + ${lastBuildString} diff --git a/src/main/resources/jenkins/plugins/extracolumns/LastBuildColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/LastBuildColumn/config.jelly index f06903c..0343c72 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/LastBuildColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/LastBuildColumn/config.jelly @@ -24,30 +24,33 @@ THE SOFTWARE. - -

${%This column shows the last build.}

- - - - - - - - - - - - -
+ +

${%This column shows the last build.}

+ +
+ +
+
+ +
+ +
+
+ + + + + +
diff --git a/src/main/resources/jenkins/plugins/extracolumns/LastBuildConsoleColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/LastBuildConsoleColumn/column.jelly index 81cd28b..edd8938 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/LastBuildConsoleColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/LastBuildConsoleColumn/column.jelly @@ -28,7 +28,7 @@ THE SOFTWARE. - + diff --git a/src/main/resources/jenkins/plugins/extracolumns/LastBuildConsoleColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/LastBuildConsoleColumn/config.jelly index 4514a55..18e3579 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/LastBuildConsoleColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/LastBuildConsoleColumn/config.jelly @@ -24,14 +24,6 @@ THE SOFTWARE. - - - - - - -

${%This column adds a shortcut to the console output of the last/current build.}

- - -
+ +

${%This column adds a shortcut to the console output of the last/current build.}

diff --git a/src/main/resources/jenkins/plugins/extracolumns/LastBuildNodeColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/LastBuildNodeColumn/column.jelly index 0cdbaec..482f9e3 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/LastBuildNodeColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/LastBuildNodeColumn/column.jelly @@ -27,14 +27,14 @@ THE SOFTWARE. - - Master + + ${%Built-In Node} N/A - ${node} + ${node} diff --git a/src/main/resources/jenkins/plugins/extracolumns/LastBuildNodeColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/LastBuildNodeColumn/config.jelly index 0ee0d1b..8891cd2 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/LastBuildNodeColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/LastBuildNodeColumn/config.jelly @@ -24,14 +24,6 @@ THE SOFTWARE. - - - - - - -

${%This column shows the name of the node on which the last build was executed.}

- - -
+ +

${%This column shows the name of the node on which the last build was executed.}

diff --git a/src/main/resources/jenkins/plugins/extracolumns/LastJobConfigurationModificationColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/LastJobConfigurationModificationColumn/config.jelly index c469c9c..928f5e8 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/LastJobConfigurationModificationColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/LastJobConfigurationModificationColumn/config.jelly @@ -24,7 +24,5 @@ - -

${%This column shows the date of the last job configuration modification.}

-
+

${%This column shows the date of the last job configuration modification.}

\ No newline at end of file diff --git a/src/main/resources/jenkins/plugins/extracolumns/SCMTypeColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/SCMTypeColumn/config.jelly index ab58cc5..b71cf13 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/SCMTypeColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/SCMTypeColumn/config.jelly @@ -24,7 +24,5 @@ - -

${%This column shows the type of source code management that is used.}

-
+

${%This column shows the type of source code management that is used.}

\ No newline at end of file diff --git a/src/main/resources/jenkins/plugins/extracolumns/SlaveOrLabelColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/SlaveOrLabelColumn/column.jelly index ebc51fa..2ecb254 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/SlaveOrLabelColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/SlaveOrLabelColumn/column.jelly @@ -30,7 +30,8 @@ N/A N/A - ${label.getName()} + ${label.getName()} + ${label.getName()} ${label.getName()} ${desc} diff --git a/src/main/resources/jenkins/plugins/extracolumns/SlaveOrLabelColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/SlaveOrLabelColumn/config.jelly index 9d04fb4..3c19351 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/SlaveOrLabelColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/SlaveOrLabelColumn/config.jelly @@ -24,7 +24,5 @@ - -

${%This column shows build processor or build processor label restrictions of a job.}

-
+

${%This column shows build processor or build processor label restrictions of a job.}

\ No newline at end of file diff --git a/src/main/resources/jenkins/plugins/extracolumns/TestResultColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/TestResultColumn/config.jelly index 48884a1..920b56a 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/TestResultColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/TestResultColumn/config.jelly @@ -24,17 +24,17 @@ THE SOFTWARE. - -

${%This column shows the test result of the last build.}

- - - -
+

${%This column shows the test result of the last build.}

+ +
+ +
+
diff --git a/src/main/resources/jenkins/plugins/extracolumns/UserNameColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/UserNameColumn/column.jelly index 4709b92..b7ec281 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/UserNameColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/UserNameColumn/column.jelly @@ -31,10 +31,10 @@ THE SOFTWARE. N/A - ${userIdCause.userName} + ${userIdCause.userName} - ${userIdCause.userName} + ${userIdCause.userName} diff --git a/src/main/resources/jenkins/plugins/extracolumns/UserNameColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/UserNameColumn/config.jelly index a9f0ff1..3a2360b 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/UserNameColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/UserNameColumn/config.jelly @@ -24,14 +24,6 @@ THE SOFTWARE. - - - - - - -

${%This column shows the name of the user that started the last build.}

- - -
+ +

${%This column shows the name of the user that started the last build.}

diff --git a/src/main/resources/jenkins/plugins/extracolumns/WorkspaceColumn/column.jelly b/src/main/resources/jenkins/plugins/extracolumns/WorkspaceColumn/column.jelly index 7b51f48..c7e0f45 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/WorkspaceColumn/column.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/WorkspaceColumn/column.jelly @@ -35,8 +35,8 @@ THE SOFTWARE. - - + + diff --git a/src/main/resources/jenkins/plugins/extracolumns/WorkspaceColumn/config.jelly b/src/main/resources/jenkins/plugins/extracolumns/WorkspaceColumn/config.jelly index 9daf7ce..bd559a1 100644 --- a/src/main/resources/jenkins/plugins/extracolumns/WorkspaceColumn/config.jelly +++ b/src/main/resources/jenkins/plugins/extracolumns/WorkspaceColumn/config.jelly @@ -24,14 +24,6 @@ THE SOFTWARE. - - - - - - -

${%This column provides a link to the workspace.}

- - -
+ +

${%This column provides a link to the workspace.}