Skip to content

Commit 79a87bf

Browse files
MarkEWaitegit-client-user
andauthored
Explicitly declare bundled artifacts (#1321)
* Explicitly declare bundled artifacts Do not allow additions to the bundled dependencies without a change to the list of bundledArtifacts. Avoid the mistakes made in the past when a new transitive dependency was inadvertently added to the plugin and bundled into the hpi / jpi file. Draft until the release of pull request: * jenkinsci/maven-hpi-plugin#771 Testing done: Confirmed that compilation passes and a single test passes. Rely on ci.jenkins.io for more complete testing * Use parent pom 5.22 with strictBundledArtifacts --------- Co-authored-by: git-client-user <git-client-user@example.com>
1 parent 62c3398 commit 79a87bf

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pom.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>org.jenkins-ci.plugins</groupId>
77
<artifactId>plugin</artifactId>
8-
<version>5.19</version>
8+
<version>5.22</version>
99
<relativePath />
1010
</parent>
1111

@@ -37,6 +37,8 @@
3737
<!-- Character set tests fail unless file.encoding is set -->
3838
<argLine>-Dfile.encoding=${project.build.sourceEncoding}</argLine>
3939
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
40+
<hpi.bundledArtifacts>JavaEWAH,org.eclipse.jgit,org.eclipse.jgit.http.apache,org.eclipse.jgit.http.server,org.eclipse.jgit.lfs,org.eclipse.jgit.ssh.apache</hpi.bundledArtifacts>
41+
<hpi.strictBundledArtifacts>true</hpi.strictBundledArtifacts>
4042
<!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
4143
<jenkins.baseline>2.504</jenkins.baseline>
4244
<jenkins.version>${jenkins.baseline}.1</jenkins.version>

0 commit comments

Comments
 (0)