Fix warnings in UI module

Author: uhafner

ui-tests/src/main/java/io/jenkins/plugins/forensics/git/DetailsTable.java

@@ -1,20 +1,21 @@
 package io.jenkins.plugins.forensics.git;
 
+import org.openqa.selenium.By;
+import org.openqa.selenium.Keys;
+import org.openqa.selenium.WebElement;
+
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
+import java.util.Locale;
 import java.util.stream.Collectors;
 
-import org.openqa.selenium.By;
-import org.openqa.selenium.Keys;
-import org.openqa.selenium.WebElement;
-
 /**
  * Page object for the details-table of the forensics view.
  *
  * @author Mitja Oldenbourg
  */
-public class DetailsTable {
+public final class DetailsTable {
     static final String FILE_NAME = "File";
     static final String AUTHORS = "#Authors";
     static final String COMMITS = "#Commits";
@@ -165,6 +166,6 @@ private void updateTableRows() {
     }
 
     private WebElement getHeaderAsWebElement(final int option) {
-        return page.findElement(By.xpath(String.format(".//thead/tr/th[%d]", option)));
+        return page.findElement(By.xpath(String.format(Locale.ENGLISH, ".//thead/tr/th[%d]", option)));
     }
 }

ui-tests/src/main/java/io/jenkins/plugins/forensics/git/ScmForensics.java

@@ -1,12 +1,12 @@
 package io.jenkins.plugins.forensics.git;
 
-import java.net.URL;
-
 import org.apache.commons.lang3.StringUtils;
 import org.openqa.selenium.By;
 
 import com.google.inject.Injector;
 
+import java.net.URL;
+
 import org.jenkinsci.test.acceptance.po.Build;
 import org.jenkinsci.test.acceptance.po.PageObject;
 
@@ -52,7 +52,7 @@ public ScmForensics(final Injector injector, final URL url, final String id) {
     public int getTotal() {
         String total = find(By.id("forensics_info")).getText();
 
-        return Integer.parseInt(StringUtils.substringAfter(total, "of ").split(" ")[0]);
+        return Integer.parseInt(StringUtils.substringAfter(total, "of ").split(" ", 0)[0]);
     }
 }
 

ui-tests/src/main/java/io/jenkins/plugins/forensics/git/ScrollerUtil.java

@@ -19,8 +19,8 @@ public final class ScrollerUtil {
      */
     public static void hideScrollerTabBar(final WebDriver driver) {
         WebElement element = driver.findElement(By.xpath("//div[contains(@class, 'jenkins-config-widgets')]"));
-        if (driver instanceof JavascriptExecutor) {
-            ((JavascriptExecutor) driver).executeScript("arguments[0].style.visibility='hidden'", element);
+        if (driver instanceof JavascriptExecutor executor) {
+            executor.executeScript("arguments[0].style.visibility='hidden'", element);
         }
     }
 

ui-tests/src/main/java/io/jenkins/plugins/forensics/git/Summary.java

@@ -1,13 +1,13 @@
 package io.jenkins.plugins.forensics.git;
 
-import java.util.List;
-import java.util.regex.Pattern;
-import java.util.stream.Collectors;
-
 import org.apache.commons.lang3.StringUtils;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
 
+import java.util.List;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+
 import org.jenkinsci.test.acceptance.po.Build;
 import org.jenkinsci.test.acceptance.po.PageObject;
 
@@ -34,7 +34,7 @@ public class Summary extends PageObject {
      * @param id
      *         the type of the result page (e.g. simian, checkstyle, cpd, etc.)
      */
-    @SuppressWarnings("PMD.ConstructorCallsOverridableMethod")
+    @SuppressWarnings({"PMD.ConstructorCallsOverridableMethod", "this-escape"})
     public Summary(final Build parent, final String id) {
         super(parent, parent.url(id));
 

ui-tests/src/test/java/io/jenkins/plugins/forensics/git/SmokeTests.java

@@ -1,7 +1,5 @@
 package io.jenkins.plugins.forensics.git;
 
-import java.util.List;
-
 import org.junit.Test;
 
 import org.jenkinsci.test.acceptance.junit.AbstractJUnitTest;
@@ -30,8 +28,8 @@ public class SmokeTests extends AbstractJUnitTest {
      */
     @Test
     public void shouldMineGitHubRepository() {
-        WorkflowJob job = createJob();
-        Build build = buildSuccessfully(job);
+        var job = createJob();
+        var build = buildSuccessfully(job);
 
         assertThat(build.getConsole()).contains(
                 "Found 428 commits",
@@ -40,14 +38,14 @@ public void shouldMineGitHubRepository() {
 
         build.open();
 
-        Summary commitStatistics = new Summary(build, "commits-of-" + SCM_HASH);
+        var commitStatistics = new Summary(build, "commits-of-" + SCM_HASH);
         assertThat(commitStatistics).hasTitle("SCM: " + SCM_KEY);
         assertThat(commitStatistics).hasDetails("Initial recording of 200 commits", "Latest commit: 28af63d");
         assertThat(commitStatistics.openLinkByText("28af63d")).isEqualTo("https://github.com/jenkinsci/git-forensics-plugin/commit/28af63def44286729e3b19b03464d100fd1d0587");
 
         build.open();
 
-        Summary scmForensics = new Summary(build, "scm-forensics-of-" + SCM_HASH);
+        var scmForensics = new Summary(build, "scm-forensics-of-" + SCM_HASH);
         assertThat(scmForensics).hasTitle("SCM Forensics: " + SCM_KEY);
         assertThat(scmForensics).hasDetails("51 repository files (total lines of code: 6066, total churn: 16966)",
                 "New commits: 402 (from 4 authors in 131 files)",
@@ -57,11 +55,11 @@ public void shouldMineGitHubRepository() {
 
         // TODO: navigate from summary
 
-        ScmForensics forensicsDetails = new ScmForensics(build, "forensics");
+        var forensicsDetails = new ScmForensics(build, "forensics");
         forensicsDetails.open();
         assertThat(forensicsDetails.getTotal()).isEqualTo(51);
 
-        DetailsTable detailsTable = new DetailsTable(forensicsDetails);
+        var detailsTable = new DetailsTable(forensicsDetails);
         assertTableHeaders(detailsTable);
         assertTableEntriesAndSorting(detailsTable);
         assertSearch(detailsTable);
@@ -89,7 +87,7 @@ private WorkflowJob createJob() {
     private void assertTableHeaders(final DetailsTable detailsTable) {
         assertThat(detailsTable.getHeaderSize()).isEqualTo(7);
 
-        List<String> tableHeaders = detailsTable.getHeaders();
+        var tableHeaders = detailsTable.getHeaders();
         assertThat(tableHeaders.get(0)).isEqualTo(FILE_NAME);
         assertThat(tableHeaders.get(1)).isEqualTo(AUTHORS);
         assertThat(tableHeaders.get(2)).isEqualTo(COMMITS);
@@ -179,7 +177,7 @@ private void assertPagination(final DetailsTable detailsTable) {
 
     private void assertRow(final DetailsTable detailsTable,
             final int rowNum, final String fileName, final int numAuthors, final int numCommits) {
-        DetailsTableRow secondRow = detailsTable.getTableRows().get(rowNum);
+        var secondRow = detailsTable.getTableRows().get(rowNum);
 
         assertThat(secondRow.getFileName()).isEqualTo(fileName);
         assertThat(secondRow.getNumberOfAuthors()).isEqualTo(numAuthors);