Fix javac warnings

Author: uhafner

plugin/pom.xml

@@ -3,7 +3,7 @@
   <modelVersion>4.0.0</modelVersion>
 
   <parent>
-  <groupId>io.jenkins.plugins</groupId>
+    <groupId>io.jenkins.plugins</groupId>
     <artifactId>git-forensics-parent</artifactId>
     <version>${revision}.${changelist}</version>
   </parent>

plugin/src/main/java/io/jenkins/plugins/forensics/git/blame/GitBlamer.java

@@ -51,6 +51,7 @@ class GitBlamer extends Blamer {
     static final String NO_HEAD_ERROR = "Could not retrieve HEAD commit, aborting";
     static final String BLAME_ERROR = "Computing blame information failed with an exception:";
 
+    @SuppressWarnings("serial")
     private final GitClient git;
     private final String gitCommit;
 

plugin/src/main/java/io/jenkins/plugins/forensics/git/delta/GitDeltaCalculator.java

@@ -32,6 +32,7 @@ public class GitDeltaCalculator extends DeltaCalculator {
     static final String DELTA_ERROR = "Computing delta information failed with an exception:";
     static final String EMPTY_COMMIT_ERROR = "Calculating the Git code delta is not possible due to an unknown commit ID";
 
+    @SuppressWarnings("serial")
     private final GitClient git;
     private final String scmKey;
 
@@ -51,6 +52,7 @@ public GitDeltaCalculator(final GitClient git, final String scmKey) {
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public Optional<Delta> calculateDelta(final Run<?, ?> build, final Run<?, ?> referenceBuild,
             final String scmKeyFilter, final FilteredLog log) {
         var scm = StringUtils.defaultIfEmpty(scmKeyFilter, scmKey);

plugin/src/main/java/io/jenkins/plugins/forensics/git/miner/CommitStatisticsStep.java

@@ -225,6 +225,7 @@ public String getDisplayName() {
         }
 
         @Override
+        @SuppressWarnings("rawtypes")
         public boolean isApplicable(final Class<? extends AbstractProject> jobType) {
             return true;
         }

plugin/src/main/java/io/jenkins/plugins/forensics/git/miner/GitRepositoryMiner.java

@@ -31,6 +31,7 @@ public class GitRepositoryMiner extends RepositoryMiner {
     @Serial
     private static final long serialVersionUID = 1157958118716013983L;
 
+    @SuppressWarnings("serial")
     private final GitClient gitClient;
 
     GitRepositoryMiner(final GitClient gitClient) {

plugin/src/main/java/io/jenkins/plugins/forensics/git/reference/BuildCommits.java

@@ -23,7 +23,8 @@ class BuildCommits implements Serializable {
 
     private final String previousBuildCommit;
 
-    private final List<String> commits = new ArrayList<>();
+    @SuppressWarnings("PMD.LooseCoupling")
+    private final ArrayList<String> commits = new ArrayList<>();
 
     private ObjectId head = ObjectId.zeroId();
     private ObjectId target = ObjectId.zeroId();

plugin/src/main/java/io/jenkins/plugins/forensics/git/reference/GitCommitsRecord.java

@@ -1,6 +1,6 @@
 package io.jenkins.plugins.forensics.git.reference;
 
-import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.eclipse.jgit.lib.ObjectId;
 
 import edu.hm.hafner.util.FilteredLog;
@@ -42,7 +42,7 @@ public class GitCommitsRecord implements RunAction2, Serializable {
      */
     public static Optional<GitCommitsRecord> findRecordForScm(final Run<?, ?> build, final String scmKey) {
         return build.getActions(GitCommitsRecord.class).stream()
-                .filter(record -> StringUtils.containsIgnoreCase(record.getScmKey(), scmKey))
+                .filter(record -> Strings.CI.contains(record.getScmKey(), scmKey))
                 .findAny();
     }
 
@@ -58,9 +58,12 @@ public static Optional<GitCommitsRecord> findRecordForScm(final Run<?, ?> build,
     private final RecordingType recordingType;
     private final String latestCommitLink;
     private final String targetParentCommit;
-    private final List<String> commits;
-    private final List<String> errorMessages;
-    private final List<String> infoMessages;
+    @SuppressWarnings("PMD.LooseCoupling")
+    private final ArrayList<String> commits;
+    @SuppressWarnings("PMD.LooseCoupling")
+    private final ArrayList<String> errorMessages;
+    @SuppressWarnings("PMD.LooseCoupling")
+    private final ArrayList<String> infoMessages;
 
     /** Determines if this record is the starting point or an incremental record that is based on the previous record. */
     enum RecordingType {

pom.xml

@@ -6,7 +6,7 @@
   <parent>
     <groupId>org.jvnet.hudson.plugins</groupId>
     <artifactId>analysis-pom</artifactId>
-    <version>11.2852.v88a_36fe3230d</version>
+    <version>11.2867.v81ec3848d647</version>
     <relativePath />
   </parent>