Skip to content

Commit ef09b57

Browse files
authored
Remove character set dependency from assertion (#150)
The assertion is intended to confirm that the correct item is in the list, not that the current environment is using a specific character set. Removes the non-ASCII character from the assertion while retaining the SHA-1 segment and the date string.
1 parent 6f60af2 commit ef09b57

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

src/test/java/net/uaznia/lukanus/hudson/plugins/gitparameter/GitParameterDefinitionTest.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -390,13 +390,7 @@ void testDoFillValueItems_listRevisions(JenkinsRule jenkins) throws Exception {
390390
assertNotNull(build);
391391
ItemsErrorModel items = def.getDescriptor().doFillValueItems(project, def.getName());
392392
assertTrue(isListBoxItem(items, "00a8385cba1e4e32cf823775e2b3dbe5eb27931d"));
393-
if (!Functions.isWindows() || System.getenv("CI") == null) {
394-
// Windows agents on AWS ci.jenkins.io changed character set configuration compared to Azure
395-
// Only test when not on Windows and not on a CI configuration
396-
// TODO: Remove conditional when AWS ci.jenkins.io agent character set config is updated
397-
assertTrue(isListBoxItemName(
398-
items, "00a8385c 2011-10-30 17:11 Łukasz Miłkowski <lukanus@uaznia.net> initial readme"));
399-
}
393+
assertTrue(isListBoxItemName(items, "00a8385c 2011-10-30 17:11 "));
400394
}
401395

402396
@Test

0 commit comments

Comments
 (0)