Merge pull request #801 from darxriggs/unused-assignments

Remove unused assignments

Author: MarkEWaite

src/main/java/hudson/plugins/git/GitSCM.java

@@ -144,7 +144,7 @@ public class GitSCM extends GitSCMBackwardCompatibility {
     private boolean doGenerateSubmoduleConfigurations;
 
     @CheckForNull
-    public String gitTool = null;
+    public String gitTool;
     @CheckForNull
     private GitRepositoryBrowser browser;
     private Collection<SubmoduleConfig> submoduleCfg;
@@ -732,7 +732,7 @@ private PollingResult compareRemoteRevisionWithImpl(Job<?, ?> project, Launcher
                             if (!branchSpec.matches(head, environment)) {
 
                                 // convert head `refs/(heads|tags|whatever)/branch` into shortcut notation `remote/branch`
-                                String name = head;
+                                String name;
                                 Matcher matcher = GIT_REF.matcher(head);
                                 if (matcher.matches()) name = remote + head.substring(matcher.group(1).length());
                                 else name = remote + "/" + head;

src/main/java/hudson/plugins/git/browser/GitLab.java

@@ -98,7 +98,7 @@ public URL getChangeSetLink(GitChangeSet changeSet) throws IOException {
     @Override
     public URL getDiffLink(Path path) throws IOException {
         final GitChangeSet changeSet = path.getChangeSet();
-        String filelink = null;
+        String filelink;
         if(getVersionDouble() < 8.0) {
                 filelink = "#" + path.getPath();
         } else

src/main/java/hudson/plugins/git/extensions/impl/CloneOption.java

@@ -33,7 +33,7 @@ public class CloneOption extends GitSCMExtension {
     private final String reference;
     private final Integer timeout;
     private Integer depth;
-    private boolean honorRefspec = false;
+    private boolean honorRefspec;
 
     public CloneOption(boolean shallow, String reference, Integer timeout) {
         this(shallow, false, reference, timeout);

src/main/java/hudson/plugins/git/extensions/impl/SparseCheckoutPaths.java

@@ -19,7 +19,7 @@
 import java.util.Objects;
 
 public class SparseCheckoutPaths extends GitSCMExtension {
-    private List<SparseCheckoutPath> sparseCheckoutPaths = Collections.emptyList();
+    private List<SparseCheckoutPath> sparseCheckoutPaths;
 
     @DataBoundConstructor
     public SparseCheckoutPaths(List<SparseCheckoutPath> sparseCheckoutPaths) {