Enhance notifyCommit logging

[MarkRx]

What feature do you want to see added?

I've been working with Jenkins for years and have had to debug situations where the system wasn't triggering jobs through the git notifyCommit logging. Situations that contributed to miss-configuration or discovering bugs were using more complicated setups (such as the branch source plugin) as well as proxying / dedicated alias server nodes.

There are a few spots I plan on adding some FINER logging to onNotifyCommit to make future issues for anyone who needs to troubleshoot commit notifications easier

Upstream changes

No response

Are you interested in contributing this feature?

Yes it's on my list of things to do

[Amit-kumar80844]

Hi, I’m new to Jenkins contribution and would like to work on this issue.
I plan to add additional debug-level logging around the onNotifyCommit handling path to make troubleshooting easier.
I’ll keep the change small and focused. Please let me know if this sounds ok for you.

[MarkEWaite]

Hi, I’m new to Jenkins contribution and would like to work on this issue. I plan to add additional debug-level logging around the onNotifyCommit handling path to make troubleshooting easier. I’ll keep the change small and focused. Please let me know if this sounds ok for you.

I think it is not a good use of your time to add logging in an area where @MarkRx is already adding logging. I think you should choose a different issue rather than working on one that someone else is already addressing.

[Amit-kumar80844]

Thanks for pointing that out. I’ll look into a different issue instead.

[Itz-bhavii]

Hi @MarkEWaite ,
I wanted to follow up on this issue. I saw the earlier discussion where a contributor was advised to step back since additional logging was already planned, but there hasn’t been any recent progress or updates for about a month.

I wanted to check whether this is still being actively worked on. If not, and if you think it would be appropriate, I’d be interested in trying to work on this issue.

Please let me know if that would be okay.

Thanks.

[MarkEWaite]

I wanted to check whether this is still being actively worked on. If not, and if you think it would be appropriate, I’d be interested in trying to work on this issue.

This is not a good first issue for a new contributor.

@MarkRx has significant prior experience with notifyCommit. He has an understanding of the type of logging that is needed. However, the issue description does not provide enough details of the places where that logging would have helped.

Unless you have similar experience with diagnosing failures in notifyCommit, I think you would just be guessing to try to find the logging entries that would be most useful to someone that is trying to diagnose an issue. Having you guess at the needed logging additions and then having me guess if they meet the needs that @MarkRx has does not feel like an effective path forward.

[Itz-bhavii]

Thanks for the clarification and for taking the time to explain the context. That makes sense.

I’ll look for another issue that’s a better fit for a new contributor. Thanks again for the guidance.