Switch to using HTMLUnit-compatible JS (#1846)

Co-authored-by: Daniel Beck <[email protected]>

Author: daniel-beck

src/main/resources/com/dabsquared/gitlabjenkins/GitLabPushTrigger/adjunct.js

@@ -1,6 +1,8 @@
 Behaviour.specify("BUTTON.gitlab_plugin-generate", "gitlab_plugin-generate", 0, function (e) {
     e.onclick = function (evt) {
-        document.getElementById('gitlab_plugin_secretToken').value = [...Array(32)].map(() => Math.floor(Math.random() * 16).toString(16)).join('');
+        const array = new Uint32Array(4);
+        self.crypto.getRandomValues(array);
+        document.getElementById('gitlab_plugin_secretToken').value = Array.from(array).map(e => e.toString(16)).join("");
         evt.preventDefault();
     };
 });

src/test/java/com/dabsquared/gitlabjenkins/util/JavaScriptTest.java

@@ -0,0 +1,26 @@
+package com.dabsquared.gitlabjenkins.util;
+
+import com.dabsquared.gitlabjenkins.GitLabPushTrigger;
+import hudson.model.FreeStyleProject;
+import java.io.IOException;
+import org.junit.jupiter.api.Test;
+import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.junit.jupiter.WithJenkins;
+import org.xml.sax.SAXException;
+
+/**
+ * JS in HTMLUnit isn't great, so ensure our JS doesn't cause it to fall over.
+ */
+@WithJenkins
+public class JavaScriptTest {
+    @Test
+    void testJavaScriptExecution(JenkinsRule j) throws IOException, SAXException {
+        final FreeStyleProject fs = j.createFreeStyleProject();
+        final GitLabPushTrigger trigger = new GitLabPushTrigger();
+        fs.addTrigger(trigger);
+        fs.save();
+        try (JenkinsRule.WebClient wc = j.createWebClient()) {
+            wc.getPage(fs, "configure");
+        }
+    }
+}