Ensure Gradle Convention Plugin follows Jenkins build conventions

[aaravmahajanofficial]

Hi @timja, thanks for your clarification 👍. I would apply the fix.

This shouldn't be required at least for plugins under https://github.com/jenkinsci

We do not use data maintained in pom ( / generated pom) files for generating lists of developers as the data quality is really poor.

We use the data in the https://github.com/jenkins-infra/repository-permissions-updater/ project along with display names from https://accounts.jenkins.io/
Originally posted by @timja in jenkins-infra/jenkins.io#8391 (comment)

---

Also, I want to have your opinion on other properties of the jenkinsConvention plugin extension.

Below is my implementation (these handle the metadata for update-center, pom.xml):

PluginExtension.kt (configs the user-facing properties)

JPIPluginManager.kt (bridges convention-plugin with JPI Plugin)

Kindly check if there are similar tweaks needed in any of these, (apart from 'developers' block), any missing properties, etc.; would love to fix that too.

Thanks! 🙂

[timja]

It shouldn't be published under your own package if in Jenkinsci.

It should be under io.jenkins.libs I think.

---

Best would be to go through https://github.com/jenkinsci/plugin-pom/ (and https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml) making sure everything works.

i.e.

• how do projects with frontend setups work.
• Are frontend tests published correctly.
• Option to ban JUnit 4 usage
• Spotbugs
• Spotless
• Code coverage
• Mockito agent
• Option to publish test jar where required
• Allow opting in to beta apis - and prevent using beta apis when not opted into.
• Are incrementals or equivalent produced

Can a plugin built with this be consumed by plugin-compat-tester, i.e in the plugin bom: http://github.com/jenkinsci/bom

[oleg-nenashev]

io.jenkins.libs

or io.jenkins.tools.gradle - it might make sense to have a group under tools as we anticipate the JPI2 plugin to be released, and it might use the new space too

[timja]

yeah that makes sense ^

[aaravmahajanofficial]

Thanks @timja, for the review!
For the PCT part, I have already opened a draft PR. It's WIP.
I got some good reviews from @oleg-nenashev. You can also have a look at that. 🙂

[oleg-nenashev]

In this ticket, it would be nice to have a list of tasks that still need to be implemented. There is #6 which is IMHO partial and not complete. I would either restructure this issue or reopen the historical one

[aaravmahajanofficial]

To-do items:

1. To test how frontend setups work with convention-plugin.
2. Are frontend tests published correctly?
3. Option to ban JUnit 4 usage
4. Mockito agent
5. Option to publish test jar where required
6. Allow opting in to beta apis - and prevent using beta apis when not opted into.

Some convention plugin & pipeline updates that might be needed for true incrementals support:

7. Ensure incrementals or equivalent produced.
   Related to: Issue #222