Add improvement for icon on sidebar report action (#334)

* Updated  getIconFileName method to handle non existing files

Author: giovanni-vaccarino

src/main/java/htmlpublisher/HtmlPublisherTarget.java

@@ -286,7 +286,13 @@ public String getIconFileName() {
                     icon = actualHtmlPublisherTarget.icon;
                 }
                 else {
-                    icon = project.getUrl() + dir().getName() + "/" + actualHtmlPublisherTarget.icon;
+                    File iconFile = new File(dir(), actualHtmlPublisherTarget.icon);
+
+                    if(iconFile.exists()){
+                        icon = project.getUrl() + dir().getName() + "/" + actualHtmlPublisherTarget.icon;
+                    }else{
+                        icon = "symbol-document-text"; 
+                    }
                 }
             } else {
                 icon = "symbol-document-text";

src/test/java/htmlpublisher/workflow/PublishHTMLStepTest.java

@@ -182,6 +182,57 @@ public void publishMissingReport_allowMissing() throws Exception {
         assertNull("Report should be missing", report);
     }
 
+    @Test
+    public void testGetIconFileNameSymbolIcon() throws Exception {
+        // Prepare the environment
+        writeTestHTML("index.html");
+        
+        // Run the project
+        HtmlPublisherTarget target = new HtmlPublisherTarget("testReport", TEST_REPORT_DIR, "index.html", true, false, false);
+        target.setIcon("symbol-custom-icon");
+        setupAndRunProject(target);
+        
+        // Verify that getIconFileName() correctly returns the custom icon
+        HtmlPublisherTarget.HTMLAction jobReport = target.new HTMLAction(job, target); 
+        assertNotNull("Report should exist", jobReport);
+        assertEquals("symbol-custom-icon", jobReport.getIconFileName());
+    }
+
+    @Test
+    public void testGetIconFileNameCustomPath() throws Exception {
+        // Prepare the environment
+        writeTestHTML("index.html");
+        testReportDir.mkdirs();
+        File customIconFile = new File(testReportDir, "custom-icon.png");
+        customIconFile.createNewFile();
+
+        // Run the project
+        HtmlPublisherTarget target = new HtmlPublisherTarget("testReport", TEST_REPORT_DIR, "index.html", true, false, false);
+        target.setIcon("custom-icon.png");
+        setupAndRunProject(target);
+        
+        // Verify that getIconFileName() correctly returns the specified file
+        HtmlPublisherTarget.HTMLAction jobReport = target.new HTMLAction(job, target); 
+        assertNotNull("Report should exist", jobReport);
+        assertTrue("Icon should contain project URL", jobReport.getIconFileName().contains("custom-icon.png"));
+    }
+
+    @Test
+    public void testGetIconFileNameDefaultIfMissingFile() throws Exception {
+        // Prepare the environment
+        writeTestHTML("index.html");
+
+        // Run the project
+        HtmlPublisherTarget target = new HtmlPublisherTarget("testReport", TEST_REPORT_DIR, "index.html", true, false, false);
+        target.setIcon("custom-icon.png");
+        setupAndRunProject(target);
+        
+        // Verify that getIconFileName() correctly returns the default icon
+        HtmlPublisherTarget.HTMLAction jobReport = target.new HTMLAction(job, target); 
+        assertNotNull("Report should exist", jobReport);
+        assertEquals("symbol-document-text", jobReport.getIconFileName());
+    }
+
     private void writeTestHTML(String fileName) throws Exception {
         // Prepare the test file
         if (!testReportDir.exists() && !testReportDir.mkdirs()) {