Skip to content

Commit 3ade255

Browse files
committed
Fixed grammar.
1 parent 6b12b6a commit 3ade255

File tree

5 files changed

+23
-21
lines changed

5 files changed

+23
-21
lines changed

ReleaseNotes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ public class MavenJobWithDetails {
6161
The `getBuilds()` method will return an empty list instead of `NULL` in cases no
6262
builds exists.
6363

64+
Fixed grammar and changed `Build.BUILD_HAS_NEVER_RAN` into `Build.BUILD_HAS_NEVER_RUN`
65+
6466
## Release 0.3.6
6567

6668
### General Changes

jenkins-client-it-docker/src/test/java/com/offbytwo/jenkins/integration/NoExecutorStartedGetJobIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public void getLastCompletedBuldShouldNotBeNull()
9393
@Test
9494
public void getLastFailedBuildShouldBeBUILD_HAS_NEVER_RAN()
9595
{
96-
assertThat( job.getLastFailedBuild() ).isEqualTo(Build.BUILD_HAS_NEVER_RAN);
96+
assertThat( job.getLastFailedBuild() ).isEqualTo(Build.BUILD_HAS_NEVER_RUN);
9797
}
9898

9999
@Test
@@ -115,13 +115,13 @@ public void getLastSuccessfulBuildShouldNotBeNull()
115115
@Test
116116
public void getLastUnstableBuildShouldBeBUILD_HAS_NEVER_RAN()
117117
{
118-
assertThat( job.getLastUnstableBuild() ).isEqualTo(Build.BUILD_HAS_NEVER_RAN);
118+
assertThat( job.getLastUnstableBuild() ).isEqualTo(Build.BUILD_HAS_NEVER_RUN);
119119
}
120120

121121
@Test
122122
public void getLastUnsuccessfulBuildShouldBeBUILD_HAS_NEVER_RAN()
123123
{
124-
assertThat( job.getLastUnsuccessfulBuild() ).isEqualTo(Build.BUILD_HAS_NEVER_RAN);
124+
assertThat( job.getLastUnsuccessfulBuild() ).isEqualTo(Build.BUILD_HAS_NEVER_RUN);
125125
}
126126

127127
@Test

jenkins-client/src/main/java/com/offbytwo/jenkins/model/Build.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class Build extends BaseModel {
1616
* This will be returned by the API in cases where no build has ever
1717
* been executed like {@link JobWithDetails#getLastBuild()} etc.
1818
*/
19-
public static final Build BUILD_HAS_NEVER_RAN = new Build (-1, -1, "UNKNOWN");
19+
public static final Build BUILD_HAS_NEVER_RUN = new Build (-1, -1, "UNKNOWN");
2020

2121
private int number;
2222
private int queueId;

jenkins-client/src/main/java/com/offbytwo/jenkins/model/JobWithDetails.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -207,98 +207,98 @@ private Build buildWithClient(Build from) {
207207

208208
/**
209209
* @return the first build which has been executed or
210-
* {@link Build#BUILD_HAS_NEVER_RAN} is this has never been
210+
* {@link Build#BUILD_HAS_NEVER_RUN} is this has never been
211211
* executed.
212212
*/
213213
public Build getFirstBuild() {
214214
if (firstBuild == null) {
215-
return Build.BUILD_HAS_NEVER_RAN;
215+
return Build.BUILD_HAS_NEVER_RUN;
216216
} else {
217217
return buildWithClient(firstBuild);
218218
}
219219
}
220220

221221
/**
222222
* @return The lastBuild. If {@link #lastBuild} has never been run
223-
* {@link Build#BUILD_HAS_NEVER_RAN} will be returned.
223+
* {@link Build#BUILD_HAS_NEVER_RUN} will be returned.
224224
*/
225225
public Build getLastBuild() {
226226
if (lastBuild == null) {
227-
return Build.BUILD_HAS_NEVER_RAN;
227+
return Build.BUILD_HAS_NEVER_RUN;
228228
} else {
229229
return buildWithClient(lastBuild);
230230
}
231231
}
232232

233233
/**
234234
* @return The lastCompletedBuild. If {@link #lastCompletedBuild} has never
235-
* been run {@link Build#BUILD_HAS_NEVER_RAN} will be returned.
235+
* been run {@link Build#BUILD_HAS_NEVER_RUN} will be returned.
236236
*/
237237
public Build getLastCompletedBuild() {
238238
if (lastCompletedBuild == null) {
239-
return Build.BUILD_HAS_NEVER_RAN;
239+
return Build.BUILD_HAS_NEVER_RUN;
240240
} else {
241241
return buildWithClient(lastCompletedBuild);
242242
}
243243
}
244244

245245
/**
246246
* @return The lastFailedBuild. If {@link #lastFailedBuild} has never been
247-
* run {@link Build#BUILD_HAS_NEVER_RAN} will be returned.
247+
* run {@link Build#BUILD_HAS_NEVER_RUN} will be returned.
248248
*/
249249
public Build getLastFailedBuild() {
250250
if (lastFailedBuild == null) {
251-
return Build.BUILD_HAS_NEVER_RAN;
251+
return Build.BUILD_HAS_NEVER_RUN;
252252
} else {
253253
return buildWithClient(lastFailedBuild);
254254
}
255255
}
256256

257257
/**
258258
* @return The lastStableBuild. If {@link #lastStableBuild} has never been
259-
* run {@link Build#BUILD_HAS_NEVER_RAN} will be returned.
259+
* run {@link Build#BUILD_HAS_NEVER_RUN} will be returned.
260260
*/
261261
public Build getLastStableBuild() {
262262
if (lastStableBuild == null) {
263-
return Build.BUILD_HAS_NEVER_RAN;
263+
return Build.BUILD_HAS_NEVER_RUN;
264264
} else {
265265
return buildWithClient(lastStableBuild);
266266
}
267267
}
268268

269269
/**
270270
* @return The lastSuccessfulBuild. If {@link #lastSuccessfulBuild} has
271-
* never been run {@link Build#BUILD_HAS_NEVER_RAN} will be
271+
* never been run {@link Build#BUILD_HAS_NEVER_RUN} will be
272272
* returned.
273273
*/
274274
public Build getLastSuccessfulBuild() {
275275
if (lastSuccessfulBuild == null) {
276-
return Build.BUILD_HAS_NEVER_RAN;
276+
return Build.BUILD_HAS_NEVER_RUN;
277277
} else {
278278
return buildWithClient(lastSuccessfulBuild);
279279
}
280280
}
281281

282282
/**
283283
* @return The lastUnstableBuild. If {@link #lastUnstableBuild} has never
284-
* been run {@link Build#BUILD_HAS_NEVER_RAN} will be returned.
284+
* been run {@link Build#BUILD_HAS_NEVER_RUN} will be returned.
285285
*/
286286
public Build getLastUnstableBuild() {
287287
if (lastUnstableBuild == null) {
288-
return Build.BUILD_HAS_NEVER_RAN;
288+
return Build.BUILD_HAS_NEVER_RUN;
289289
} else {
290290
return buildWithClient(lastUnstableBuild);
291291
}
292292
}
293293

294294
/**
295295
* @return The lastUnsuccessfulBuild. If {@link #lastUnsuccessfulBuild} has
296-
* never been run {@link Build#BUILD_HAS_NEVER_RAN} will be
296+
* never been run {@link Build#BUILD_HAS_NEVER_RUN} will be
297297
* returned.
298298
*/
299299
public Build getLastUnsuccessfulBuild() {
300300
if (lastUnsuccessfulBuild == null) {
301-
return Build.BUILD_HAS_NEVER_RAN;
301+
return Build.BUILD_HAS_NEVER_RUN;
302302
} else {
303303
return buildWithClient(lastUnsuccessfulBuild);
304304
}

jenkins-client/src/test/java/com/offbytwo/jenkins/model/JobWithDetailsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ private JobWithDetails givenNewJobWithoutAnyBuilds() {
2121
}
2222

2323
private void failIfNotBuildHasNeverRanReturned(Build build) {
24-
assertThat(build).isEqualTo(Build.BUILD_HAS_NEVER_RAN);
24+
assertThat(build).isEqualTo(Build.BUILD_HAS_NEVER_RUN);
2525
}
2626

2727
@Test

0 commit comments

Comments
 (0)