Skip to content

Commit d221182

Browse files
authored
Merge pull request #283 from tuliren/fix_typo
Fixed #282
2 parents 42a15c9 + 4e317ed commit d221182

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

ReleaseNotes.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
## Release 0.3.8 (NOT RELEASED YET)
44

5+
* [Fixed Issue 282][issue-282]
6+
7+
`NullPointerException` may be thrown if `upstreamUrl` is `null` when
8+
converting cause to `BuildCause` object.
9+
510
* [Fixed Issue 268][issue-268]
611

712
NullPointerException is thrown unless isRunning() is called first.

jenkins-client/src/main/java/com/offbytwo/jenkins/model/BuildWithDetails.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ private BuildCause convertToBuildCause(Map<String, Object> cause) {
290290
}
291291

292292
String upstreamUrl = (String) cause.get("upstreamUrl");
293-
if (!Strings.isNullOrEmpty(upstreamProject)) {
293+
if (!Strings.isNullOrEmpty(upstreamUrl)) {
294294
cause_object.setUpstreamUrl(upstreamUrl);
295295
}
296296

0 commit comments

Comments
 (0)