log appropriate error messages to build console (#759)

closes #711 #702

* Throw JiraException from getVersions method call

* Apply spotless changes

* Remove unused method

* Replace JiraException class with RestClientException class

* Handle errors of addComment and getIssue methods in their root calling methods

* Handle errors of getProjectKeys method

* Handle errors of all the other remaining methods

* Remove unnecessary multi catch

* Throw JiraException from getVersions method call

* Apply spotless changes

* Remove unused method

* Replace JiraException class with RestClientException class

* Handle errors of addComment and getIssue methods in their root calling methods

* Handle errors of getProjectKeys method

* Handle errors of all the other remaining methods

* Remove unnecessary multi catch

* Fix spotless issue

* Update for adding test cases

* - Update for Replacing "Jira Error" with Jira
- Catch specific exceptions rather than catching general Exception

* - Fix never thrown exception catch error

* - Fix test cases

* - Replace TimeoutException tests with RestclientException tests

* - Remove not thrown exception from doc

* - Fix spotless issues

* - Handle IOException and RestClientException in a single catch

* Apply CoPilot suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Hardik Rathod <hardik.rathod@fruitcore.de>
Co-authored-by: Hardikrathod01 <42797234+Hardikrathod01@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 4 people

src/main/java/hudson/plugins/jira/JiraCreateIssueNotifier.java

@@ -2,6 +2,7 @@
 
 import static hudson.plugins.jira.JiraRestService.BUG_ISSUE_TYPE_ID;
 
+import com.atlassian.jira.rest.client.api.RestClientException;
 import com.atlassian.jira.rest.client.api.StatusCategory;
 import com.atlassian.jira.rest.client.api.domain.Issue;
 import com.atlassian.jira.rest.client.api.domain.IssueType;
@@ -164,12 +165,16 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
         }
 
         if (currentBuildResult != Result.ABORTED && previousBuild != null) {
-            if (currentBuildResult == Result.FAILURE) {
-                currentBuildResultFailure(build, listener, previousBuildResult, filename, vars);
-            }
+            try {
+                if (currentBuildResult == Result.FAILURE) {
+                    currentBuildResultFailure(build, listener, previousBuildResult, filename, vars);
+                }
 
-            if (currentBuildResult == Result.SUCCESS) {
-                currentBuildResultSuccess(build, listener, previousBuildResult, filename, vars);
+                if (currentBuildResult == Result.SUCCESS) {
+                    currentBuildResultSuccess(build, listener, previousBuildResult, filename, vars);
+                }
+            } catch (RestClientException e) {
+                listener.getLogger().println(e.getMessage());
             }
         }
         return true;
@@ -342,7 +347,7 @@ private void currentBuildResultFailure(
             Result previousBuildResult,
             String filename,
             EnvVars vars)
-            throws InterruptedException, IOException {
+            throws InterruptedException, IOException, RestClientException {
 
         if (previousBuildResult == Result.FAILURE) {
             String comment = String.format("Build is still failing.%nFailed run: %s", getBuildDetailsString(vars));

src/main/java/hudson/plugins/jira/JiraEnvironmentVariableBuilder.java

@@ -1,5 +1,6 @@
 package hudson.plugins.jira;
 
+import com.atlassian.jira.rest.client.api.RestClientException;
 import hudson.Extension;
 import hudson.Launcher;
 import hudson.model.AbstractBuild;
@@ -50,7 +51,13 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
             return false;
         }
 
-        Set<String> ids = getIssueSelector().findIssueIds(build, site, listener);
+        Set<String> ids;
+        try {
+            ids = getIssueSelector().findIssueIds(build, site, listener);
+        } catch (RestClientException e) {
+            listener.getLogger().println(e.getMessage());
+            return false;
+        }
 
         String idList = StringUtils.join(ids, ",");
         Integer idListSize = ids.size();

src/main/java/hudson/plugins/jira/JiraIssueUpdateBuilder.java

@@ -15,19 +15,15 @@
  */
 package hudson.plugins.jira;
 
+import com.atlassian.jira.rest.client.api.RestClientException;
 import hudson.EnvVars;
 import hudson.Extension;
 import hudson.Util;
-import hudson.model.AbstractProject;
-import hudson.model.Job;
-import hudson.model.Result;
-import hudson.model.Run;
-import hudson.model.TaskListener;
+import hudson.model.*;
 import hudson.tasks.BuildStepDescriptor;
 import hudson.tasks.Builder;
 import hudson.util.FormValidation;
 import java.io.IOException;
-import java.util.concurrent.TimeoutException;
 import jenkins.tasks.SimpleBuildStep;
 import org.apache.commons.lang.StringUtils;
 import org.jenkinsci.Symbol;
@@ -105,9 +101,8 @@ public void perform(Run<?, ?> run, EnvVars env, TaskListener listener) throws In
                 listener.getLogger().println(Messages.JiraIssueUpdateBuilder_SomeIssuesFailed());
                 run.setResult(Result.UNSTABLE);
             }
-        } catch (TimeoutException e) {
-            listener.getLogger().println(Messages.JiraIssueUpdateBuilder_Failed());
-            e.printStackTrace(listener.getLogger());
+        } catch (RestClientException e) {
+            listener.getLogger().println(e.getMessage());
             run.setResult(Result.FAILURE);
         }
     }

src/main/java/hudson/plugins/jira/JiraJobAction.java

@@ -1,5 +1,6 @@
 package hudson.plugins.jira;
 
+import com.atlassian.jira.rest.client.api.RestClientException;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
 import hudson.Extension;
@@ -127,8 +128,9 @@ public void onStarted(WorkflowRun workflowRun, TaskListener listener) {
             if (site != null) {
                 try {
                     setAction(parent, site);
-                } catch (IOException e) {
+                } catch (IOException | RestClientException e) {
                     LOGGER.log(Level.WARNING, "Could not set JiraJobAction for <" + parent.getFullName() + ">", e);
+                    listener.getLogger().println(e.getMessage());
                 }
             }
         }