Provide pipeline names for steps and selectors (#757)

* Provide pipeline names for steps and selectors

* Apply naming suggestions

Co-authored-by: Radek Antoniuk <521838+rantoniuk@users.noreply.github.com>

* Fix release note step name

* Adjust version step names, update tests and docs

---------

Co-authored-by: Radek Antoniuk <521838+rantoniuk@users.noreply.github.com>

Author: zbynek

docs/usage-examples.md

@@ -1,6 +1,6 @@
 # Usage examples
 
-## JiraIssueUpdater usage example
+## jiraCommentIssues usage example
 
 You need keep reference to used scm.
 As an example, you can write a flow:
@@ -9,9 +9,9 @@ As an example, you can write a flow:
 node {
     def gitScm = git url: 'git@github.com:jenkinsci/jira-plugin.git', branch: 'master'
     sh 'make something'
-    step([$class: 'hudson.plugins.jira.JiraIssueUpdater', 
-            issueSelector: [$class: 'hudson.plugins.jira.selector.DefaultIssueSelector'], 
-            scm: gitScm])            
+    jiraCommentIssues( 
+            issueSelector: DefaultSelector(), 
+            scm: gitScm)            
     gitScm = null
 }
 ```
@@ -21,42 +21,56 @@ Note that a pointer to scm class should be better cleared to not serialize scm o
 You can add some labels to issue in jira:
 
 ```groovy
-    step([$class: 'hudson.plugins.jira.JiraIssueUpdater', 
-            issueSelector: [$class: 'hudson.plugins.jira.selector.DefaultIssueSelector'], 
+    jiraCommentIssues( 
+            issueSelector: DefaultSelector(), 
             scm: gitScm,
-            labels: [ "$version", "jenkins" ]])            
+            labels: [ "$version", "jenkins" ])            
 ```
 
-## JiraIssueUpdateBuilder  usage example
+## jiraExecuteWorkflow  usage example
 
 ```groovy
 node {
-    step([$class: 'hudson.plugins.jira.JiraIssueUpdateBuilder', 
+    jiraExecuteWorkflow(
             jqlSearch: "project = EX and labels = 'jenkins' and labels = '${version}'",
             workflowActionName: 'Resolve Issue',
-            comment: 'comment'])
+            comment: 'comment')
+}
 ```
 
-## JiraCreateReleaseNotes usage example
+## jiraCreateReleaseNotes usage example
 
 ```groovy
 node {
-    wrap([$class: 'hudson.plugins.jira.JiraCreateReleaseNotes', jiraProjectKey: 'TST', 
-    jiraRelease: '1.1.1', jiraEnvironmentVariable: 'notes', jiraFilter: 'status in (Resolved, Closed)']) 
-    {
-        //do some useful here
-        //release notes can be found in environment variable jiraEnvironmentVariable
-        print env.notes
-    }
+    jiraCreateReleaseNotes(jiraProjectKey: 'TST',
+            jiraRelease: '1.1.1', jiraEnvironmentVariable: 'notes', jiraFilter: 'status in (Resolved, Closed)')
+            {
+                //do some useful here
+                //release notes can be found in environment variable jiraEnvironmentVariable
+                print env.notes
+            }
+}
 ```
 
-## JiraReleaseVersionUpdaterBuilder usage example
+## jiraMarkVersionReleased usage example
 
 ```groovy
 node {
-    step([$class: 'hudson.plugins.jira.JiraReleaseVersionUpdaterBuilder', 
+    jiraMarkVersionReleased( 
             jiraProjectKey: 'TEST', 
-            jiraRelease: '1.1.1'])            
+            jiraRelease: '1.1.1')
+}
+```
+
+## jiraUpdateIssueField usage example
+
+```groovy
+node {
+    jiraUpdateIssueField(
+            issueSelector: ExplicitSelector("JIRA-123"),
+            fieldId: "10001",
+            fieldValue: "value"
+    )
 }
 ```
 
@@ -78,7 +92,7 @@ Interface for Pipeline job types that simply want to post a comment e.g.:
 
 ```groovy
 node {
-    jiraComment(issueKey: "EX-111", body: "Job '${env.JOB_NAME}' (${env.BUILD_NUMBER}) builded. Please go to ${env.BUILD_URL}.")
+    jiraComment(issueKey: "EX-111", body: "Job '${env.JOB_NAME}' (${env.BUILD_NUMBER}) built. Please go to ${env.BUILD_URL}.")
 }
 ```
 

src/main/java/hudson/plugins/jira/JiraCreateReleaseNotes.java

@@ -19,11 +19,13 @@
 import java.util.HashMap;
 import java.util.Map;
 import jenkins.tasks.SimpleBuildWrapper;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 public class JiraCreateReleaseNotes extends SimpleBuildWrapper {
 
     @Extension
+    @Symbol("jiraCreateReleaseNotes")
     public static final class Descriptor extends BuildWrapperDescriptor {
 
         @Override

src/main/java/hudson/plugins/jira/JiraIssueUpdateBuilder.java

@@ -30,6 +30,7 @@
 import java.util.concurrent.TimeoutException;
 import jenkins.tasks.SimpleBuildStep;
 import org.apache.commons.lang.StringUtils;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.QueryParameter;
 
@@ -125,6 +126,7 @@ public DescriptorImpl getDescriptor() {
      * Descriptor for {@link JiraIssueUpdateBuilder}.
      */
     @Extension
+    @Symbol("jiraExecuteWorkflow")
     public static final class DescriptorImpl extends BuildStepDescriptor<Builder> {
         /**
          * Performs on-the-fly validation of the form field 'Jql'.

src/main/java/hudson/plugins/jira/JiraIssueUpdater.java

@@ -25,6 +25,7 @@
 import java.util.List;
 import jenkins.model.Jenkins;
 import jenkins.tasks.SimpleBuildStep;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 /**
@@ -116,6 +117,7 @@ public boolean endBuild() throws InterruptedException, IOException {
         };
     }
 
+    @Symbol("jiraCommentIssues")
     public static final class DescriptorImpl extends BuildStepDescriptor<Publisher> {
         private DescriptorImpl() {
             super(JiraIssueUpdater.class);

src/main/java/hudson/plugins/jira/JiraReleaseVersionUpdaterBuilder.java

@@ -10,6 +10,7 @@
 import hudson.tasks.Builder;
 import jenkins.tasks.SimpleBuildStep;
 import net.sf.json.JSONObject;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.StaplerRequest2;
 
@@ -77,6 +78,7 @@ public Descriptor<Builder> getDescriptor() {
         return DESCRIPTOR;
     }
 
+    @Symbol("jiraMarkVersionReleased")
     public static final class DescriptorImpl extends BuildStepDescriptor<Builder> {
 
         private DescriptorImpl() {

src/main/java/hudson/plugins/jira/JiraVersionCreatorBuilder.java

@@ -10,6 +10,7 @@
 import hudson.tasks.Builder;
 import jenkins.tasks.SimpleBuildStep;
 import net.sf.json.JSONObject;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.StaplerRequest2;
 
@@ -70,6 +71,7 @@ public BuildStepDescriptor<Builder> getDescriptor() {
     @Extension
     public static final DescriptorImpl DESCRIPTOR = new DescriptorImpl();
 
+    @Symbol("jiraCreateVersion")
     public static class DescriptorImpl extends BuildStepDescriptor<Builder> {
 
         public DescriptorImpl() {

src/main/java/hudson/plugins/jira/pipeline/IssueFieldUpdateStep.java

@@ -24,6 +24,7 @@
 import java.util.List;
 import java.util.Set;
 import jenkins.tasks.SimpleBuildStep;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.DataBoundSetter;
 import org.kohsuke.stapler.QueryParameter;
@@ -161,6 +162,7 @@ public DescriptorImpl getDescriptor() {
     }
 
     @Extension
+    @Symbol("jiraUpdateIssueField")
     public static class DescriptorImpl extends BuildStepDescriptor<Builder> {
 
         public FormValidation doCheckField_id(@QueryParameter String value) throws IOException, ServletException {

src/main/java/hudson/plugins/jira/selector/DefaultIssueSelector.java

@@ -25,6 +25,7 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import org.apache.commons.lang.StringUtils;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 public class DefaultIssueSelector extends AbstractIssueSelector {
@@ -46,6 +47,7 @@ public Set<String> findIssueIds(
     }
 
     @Extension
+    @Symbol("DefaultSelector")
     public static final class DescriptorImpl extends Descriptor<AbstractIssueSelector> {
 
         @Override

src/main/java/hudson/plugins/jira/selector/ExplicitIssueSelector.java

@@ -16,6 +16,7 @@
 import java.util.List;
 import java.util.Set;
 import org.apache.commons.lang.StringUtils;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 public class ExplicitIssueSelector extends AbstractIssueSelector {
@@ -63,6 +64,7 @@ public Set<String> findIssueIds(Run<?, ?> run, JiraSite site, TaskListener liste
     }
 
     @Extension
+    @Symbol("ExplicitSelector")
     public static final class DescriptorImpl extends Descriptor<AbstractIssueSelector> {
         @Override
         public String getDisplayName() {

src/main/java/hudson/plugins/jira/selector/JqlIssueSelector.java

@@ -16,6 +16,7 @@
 import java.util.List;
 import java.util.Set;
 import java.util.concurrent.TimeoutException;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 public class JqlIssueSelector extends AbstractIssueSelector {
@@ -55,13 +56,14 @@ public Set<String> findIssueIds(Run<?, ?> run, JiraSite site, TaskListener liste
             }
 
             // deduplication
-            return new HashSet(issueKeys);
+            return new HashSet<>(issueKeys);
         } catch (TimeoutException e) {
             throw new IllegalStateException("Can't open rest session to Jira site " + site, e);
         }
     }
 
     @Extension
+    @Symbol("JqlSelector")
     public static final class DescriptorImpl extends Descriptor<AbstractIssueSelector> {
         @Override
         public String getDisplayName() {