No point checking for null, the constructor handles the null the same as the default constructor which just passes null directly into this constructor anyway. So if there's a value we get what we want, and if there's not, we still get what we want. Simpler is better.

Author: fredcooke

src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStepExecution.java

@@ -84,12 +84,7 @@ public boolean start() throws Exception {
         String name = String.format(NAME_FORMAT, stepName, randString);
         String namespace = checkNamespace(cloud, podTemplateContext);
 
-        if (step.getId() != null) {
-            newTemplate = new PodTemplate(step.getId());
-        } else {
-            newTemplate = new PodTemplate();
-        }
-
+        newTemplate = new PodTemplate(step.getId());
         newTemplate.setName(name);
         newTemplate.setNamespace(namespace);